all: add support for LLVM 19

Author: aykevl

.circleci/config.yml

@@ -10,12 +10,12 @@ commands:
  steps:
  - restore_cache:
  keys:
- - llvm-source-18-v1
+ - llvm-source-19-v1
  - run:
  name: "Fetch LLVM source"
  command: make llvm-source
  - save_cache:
- key: llvm-source-18-v1
+ key: llvm-source-19-v1
  paths:
  - llvm-project/clang/lib/Headers
  - llvm-project/clang/include
@@ -109,12 +109,12 @@ jobs:
  # "make lint" fails before go 1.21 because internal/tools/go.mod specifies packages that require go 1.21
  fmt-check: false
  resource_class: large
- test-llvm18-go123:
+ test-llvm19-go123:
  docker:
  - image: golang:1.23-bullseye
  steps:
  - test-linux:
- llvm: "18"
+ llvm: "19"
  resource_class: large
 
 workflows:
@@ -123,5 +123,5 @@ workflows:
  # This tests our lowest supported versions of Go and LLVM, to make sure at
  # least the smoke tests still pass.
  - test-llvm15-go119
- # This tests LLVM 18 support when linking against system libraries.
- - test-llvm18-go123
+ # This tests LLVM 19 support when linking against system libraries.
+ - test-llvm19-go123

.github/workflows/build-macos.yml

@@ -45,7 +45,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-source
  with:
- key: llvm-source-18-${{ matrix.os }}-v2
+ key: llvm-source-19-${{ matrix.os }}-v1
  path: |
  llvm-project/clang/lib/Headers
  llvm-project/clang/include
@@ -70,7 +70,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-build
  with:
- key: llvm-build-18-${{ matrix.os }}-v3
+ key: llvm-build-19-${{ matrix.os }}-v1
  path: llvm-build
  - name: Build LLVM
  if: steps.cache-llvm-build.outputs.cache-hit != 'true'
@@ -126,7 +126,7 @@ jobs:
  runs-on: macos-latest
  strategy:
  matrix:
- version: [16, 17, 18]
+ version: [16, 17, 18, 19]
  steps:
  - name: Set up Homebrew
  uses: Homebrew/actions/setup-homebrew@master
@@ -150,8 +150,8 @@ jobs:
  - name: Check binary
  run: tinygo version
  - name: Build TinyGo (default LLVM)
- if: matrix.version == 18
+ if: matrix.version == 19
  run: go install
  - name: Check binary
- if: matrix.version == 18
+ if: matrix.version == 19
  run: tinygo version

.github/workflows/linux.yml

@@ -48,7 +48,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-source
  with:
- key: llvm-source-18-linux-alpine-v1
+ key: llvm-source-19-linux-alpine-v1
  path: |
  llvm-project/clang/lib/Headers
  llvm-project/clang/include
@@ -73,7 +73,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-build
  with:
- key: llvm-build-18-linux-alpine-v2
+ key: llvm-build-19-linux-alpine-v1
  path: llvm-build
  - name: Build LLVM
  if: steps.cache-llvm-build.outputs.cache-hit != 'true'
@@ -205,7 +205,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-source
  with:
- key: llvm-source-18-linux-asserts-v1
+ key: llvm-source-19-linux-asserts-v1
  path: |
  llvm-project/clang/lib/Headers
  llvm-project/clang/include
@@ -230,7 +230,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-build
  with:
- key: llvm-build-18-linux-asserts-v2
+ key: llvm-build-19-linux-asserts-v1
  path: llvm-build
  - name: Build LLVM
  if: steps.cache-llvm-build.outputs.cache-hit != 'true'
@@ -321,7 +321,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-source
  with:
- key: llvm-source-18-linux-v1
+ key: llvm-source-19-linux-v1
  path: |
  llvm-project/clang/lib/Headers
  llvm-project/clang/include
@@ -346,7 +346,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-build
  with:
- key: llvm-build-18-linux-${{ matrix.goarch }}-v2
+ key: llvm-build-19-linux-${{ matrix.goarch }}-v2
  path: llvm-build
  - name: Build LLVM
  if: steps.cache-llvm-build.outputs.cache-hit != 'true'

.github/workflows/llvm.yml

@@ -35,8 +35,8 @@ jobs:
  uses: docker/metadata-action@v5
  with:
  images: |
- tinygo/llvm-18
- ghcr.io/${{ github.repository_owner }}/llvm-18
+ tinygo/llvm-19
+ ghcr.io/${{ github.repository_owner }}/llvm-19
  tags: |
  type=sha,format=long
  type=raw,value=latest

.github/workflows/nix.yml

@@ -29,7 +29,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-source
  with:
- key: llvm-source-18-linux-nix-v1
+ key: llvm-source-19-linux-nix-v1
  path: |
  llvm-project/compiler-rt
  - name: Download LLVM source

.github/workflows/sizediff-install-pkgs.sh

@@ -2,11 +2,11 @@
 # still works after checking out the dev branch (that is, when going from LLVM
 # 16 to LLVM 17 for example, both Clang 16 and Clang 17 are installed).
 
-echo 'deb https://apt.llvm.org/noble/ llvm-toolchain-noble-18 main' | sudo tee /etc/apt/sources.list.d/llvm.list
+echo 'deb https://apt.llvm.org/noble/ llvm-toolchain-noble-19 main' | sudo tee /etc/apt/sources.list.d/llvm.list
 wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
 sudo apt-get update
 sudo apt-get install --no-install-recommends -y \
- llvm-18-dev \
- clang-18 \
- libclang-18-dev \
- lld-18
+ llvm-19-dev \
+ clang-19 \
+ libclang-19-dev \
+ lld-19

.github/workflows/sizediff.yml

@@ -30,7 +30,7 @@ jobs:
  uses: actions/cache@v4
  id: cache-llvm-source
  with:
- key: llvm-source-18-sizediff-v1
+ key: llvm-source-19-sizediff-v1
  path: |
  llvm-project/compiler-rt
  - name: Download LLVM source

.github/workflows/windows.yml

@@ -47,7 +47,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-source
  with:
- key: llvm-source-18-windows-v1
+ key: llvm-source-19-windows-v1
  path: |
  llvm-project/clang/lib/Headers
  llvm-project/clang/include
@@ -72,7 +72,7 @@ jobs:
  uses: actions/cache/restore@v4
  id: cache-llvm-build
  with:
- key: llvm-build-18-windows-v2
+ key: llvm-build-19-windows-v1
  path: llvm-build
  - name: Build LLVM
  if: steps.cache-llvm-build.outputs.cache-hit != 'true'

GNUmakefile

@@ -10,7 +10,7 @@ LLD_SRC ?= $(LLVM_PROJECTDIR)/lld
 
 # Try to autodetect LLVM build tools.
 # Versions are listed here in descending priority order.
-LLVM_VERSIONS = 18 17 16 15
+LLVM_VERSIONS = 19 18 17 16 15
 errifempty = $(if $(1),$(1),$(error $(2)))
 detect = $(shell which $(call errifempty,$(firstword $(foreach p,$(2),$(shell command -v $(p) 2> /dev/null && echo $(p)))),failed to locate $(1) at any of: $(2)))
 toolSearchPathsVersion = $(1)-$(2)
@@ -147,7 +147,7 @@ endif
 MD5SUM ?= md5sum
 
 # Libraries that should be linked in for the statically linked Clang.
-CLANG_LIB_NAMES = clangAnalysis clangAPINotes clangAST clangASTMatchers clangBasic clangCodeGen clangCrossTU clangDriver clangDynamicASTMatchers clangEdit clangExtractAPI clangFormat clangFrontend clangFrontendTool clangHandleCXX clangHandleLLVM clangIndex clangLex clangParse clangRewrite clangRewriteFrontend clangSema clangSerialization clangSupport clangTooling clangToolingASTDiff clangToolingCore clangToolingInclusions
+CLANG_LIB_NAMES = clangAnalysis clangAPINotes clangAST clangASTMatchers clangBasic clangCodeGen clangCrossTU clangDriver clangDynamicASTMatchers clangEdit clangExtractAPI clangFormat clangFrontend clangFrontendTool clangHandleCXX clangHandleLLVM clangIndex clangInstallAPI clangLex clangParse clangRewrite clangRewriteFrontend clangSema clangSerialization clangSupport clangTooling clangToolingASTDiff clangToolingCore clangToolingInclusions
 CLANG_LIBS = $(START_GROUP) $(addprefix -l,$(CLANG_LIB_NAMES)) $(END_GROUP) -lstdc++
 
 # Libraries that should be linked in for the statically linked LLD.
@@ -238,7 +238,7 @@ gen-device-renesas: build/gen-device-svd
 GO111MODULE=off $(GO) fmt ./src/device/renesas
 
 $(LLVM_PROJECTDIR)/llvm:
-git clone -b tinygo_xtensa_release_18.1.2 --depth=1 https://github.com/tinygo-org/llvm-project $(LLVM_PROJECTDIR)
+git clone -b xtensa_release_19.1.2 --depth=1 https://github.com/espressif/llvm-project $(LLVM_PROJECTDIR)
 llvm-source: $(LLVM_PROJECTDIR)/llvm ## Get LLVM sources
 
 # Configure LLVM.

builder/builder_test.go

@@ -39,6 +39,7 @@ func TestClangAttributes(t *testing.T) {
 "wasm",
 "wasm-unknown",
 }
+// TODO: remove this version check.
 if hasBuiltinTools {
 // hasBuiltinTools is set when TinyGo is statically linked with LLVM,
 // which also implies it was built with Xtensa support.