Skip to content

fix: Invoke error boundaries in the correct order #16737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: Invoke error boundaries in the correct order #16737

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98bd527
failing test
elliott-with-the-longest-name-on-github Sep 9, 2025
32b51b2
better
elliott-with-the-longest-name-on-github Sep 9, 2025
602b885
better
elliott-with-the-longest-name-on-github Sep 9, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
better
  • Loading branch information
@elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github committed Sep 9, 2025
commit 32b51b286c3fe5bf565bc4afe79ef1522578d1a4
2 changes: 1 addition & 1 deletion packages/svelte/tests/runtime-runes/samples/error-boundary-23/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
import Test from './test.svelte';
</script>

<svelte:boundary onerror={(e) => {console.log(e.stack)}}>
<svelte:boundary onerror={(e) => {console.log('error caught root')}}>
<Test />
</svelte:boundary>
1 change: 0 additions & 1 deletion packages/svelte/tests/runtime-runes/samples/error-boundary-23/test.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
{count} / {test}
</svelte:boundary>


<svelte:boundary onerror={(e) => {console.log('error caught 2')}}>
<div>Count: {count}</div>
<button onclick={() => count++}>Increment</button>
Expand Down
Loading