feat: improved type messages (#551)

Author: juleswritescode

Cargo.lock

@@ -23,6 +23,7 @@ biome_js_syntax = "0.5.7"
 biome_rowan = "0.5.7"
 biome_string_case = "0.5.8"
 bpaf = { version = "0.9.15", features = ["derive"] }
+criterion = "0.5"
 crossbeam = "0.8.4"
 enumflags2 = "0.7.11"
 ignore = "0.4.23"

Cargo.toml

@@ -31,7 +31,7 @@ sqlx.workspace = true
 tokio = { version = "1.41.1", features = ["full"] }
 
 [dev-dependencies]
-criterion  = "0.5.1"
+criterion.workspace = true
 pgt_test_utils.workspace = true
 
 [lib]

crates/pgt_completions/Cargo.toml

@@ -19,8 +19,8 @@ pgt_text_size.workspace = true
 regex.workspace = true
 
 [dev-dependencies]
-criterion = "0.3"
-ntest = "0.9.3"
+criterion.workspace = true
+ntest  = "0.9.3"
 
 [[bench]]
 harness = false

crates/pgt_statement_splitter/Cargo.toml

@@ -14,21 +14,28 @@ version = "0.0.0"
 [dependencies]
 globset = "0.4.16"
 itertools = { version = "0.14.0" }
+once_cell = "1.20.2"
 pgt_console.workspace = true
 pgt_diagnostics.workspace = true
 pgt_query.workspace = true
 pgt_schema_cache.workspace = true
 pgt_text_size.workspace = true
 pgt_treesitter.workspace = true
 pgt_treesitter_grammar.workspace = true
+regex = "1.11.1"
 sqlx.workspace = true
 tokio.workspace = true
 tree-sitter.workspace = true
 uuid = { version = "1.18.1", features = ["v4"] }
 
 [dev-dependencies]
+criterion.workspace = true
 insta.workspace = true
 pgt_test_utils.workspace = true
 
+[[bench]]
+harness = false
+name = "error_rewriting"
+
 [lib]
 doctest = false

crates/pgt_typecheck/Cargo.toml

@@ -0,0 +1,55 @@
+use criterion::{Criterion, black_box, criterion_group, criterion_main};
+use pgt_typecheck::IdentifierReplacement;
+use pgt_typecheck::diagnostics::rewrite_error_message;
+
+fn benchmark_error_rewriting(c: &mut Criterion) {
+ let replacement = IdentifierReplacement {
+ original_name: "user_id".to_string(),
+ original_range: 0..7,
+ default_value: "'00000000-0000-0000-0000-000000000000'".to_string(),
+ type_name: "uuid".to_string(),
+ };
+
+ // test case 1: matching the first pattern (most common case)
+ c.bench_function("rewrite_invalid_input_syntax", |b| {
+ b.iter(|| {
+ rewrite_error_message(
+ black_box(r#"invalid input syntax for type integer: "00000000-0000-0000-0000-000000000000""#),
+ black_box(&replacement),
+ )
+ })
+ });
+
+ // test case 2: matching the operator pattern
+ c.bench_function("rewrite_operator_does_not_exist", |b| {
+ b.iter(|| {
+ rewrite_error_message(
+ black_box("operator does not exist: integer + text"),
+ black_box(&replacement),
+ )
+ })
+ });
+
+ // test case 3: no pattern matches (fallback)
+ c.bench_function("rewrite_fallback", |b| {
+ b.iter(|| {
+ rewrite_error_message(
+ black_box("some other error message that doesn't match any pattern"),
+ black_box(&replacement),
+ )
+ })
+ });
+
+ // test case 4: longer error message with first pattern
+ c.bench_function("rewrite_long_message", |b| {
+ b.iter(|| {
+ rewrite_error_message(
+ black_box(r#"invalid input syntax for type timestamp: "00000000-0000-0000-0000-000000000000" at character 45"#),
+ black_box(&replacement),
+ )
+ })
+ });
+}
+
+criterion_group!(benches, benchmark_error_rewriting);
+criterion_main!(benches);