Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Different layer defaults when using newCfgValSet instead of setVal #143

Closed
#155
Closed
Different layer defaults when using newCfgValSet instead of setVal#143
#155
Labels
fixedIssue is fixed
@markuckermann

Description

@markuckermann
markuckermann
opened on Oct 29, 2020

Subject of the issue

Just a heads up really, I'v been caught out by the defaults for newCfgValset...() being different to setVal(). It's just VAL_LAYER_BBR instead of VAL_LAYER_ALL so the settings don't take effect.

The defaults were recently changed in #134 and are set here:

SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.h

Lines 577 to 579 in 97bd455

uint8_t newCfgValset8(uint32_t keyID, uint8_t value, uint8_t layer = VAL_LAYER_BBR); //Define a new UBX-CFG-VALSET with the given KeyID and 8-bit value
uint8_t newCfgValset16(uint32_t keyID, uint16_t value, uint8_t layer = VAL_LAYER_BBR); //Define a new UBX-CFG-VALSET with the given KeyID and 16-bit value
uint8_t newCfgValset32(uint32_t keyID, uint32_t value, uint8_t layer = VAL_LAYER_BBR); //Define a new UBX-CFG-VALSET with the given KeyID and 32-bit value

Is this on purpose? I'd suggest having the same defaults across the board.

Your workbench

  • Teensy 3.6 and SFE GPS-RTK2 but it shouldn't matter.

Steps to reproduce

myGPS.newCfgValset8(CFG_MSGOUT_RTCM_3X_TYPE1005_I2C, 1); myGPS.addCfgValset8(CFG_MSGOUT_RTCM_3X_TYPE1097_I2C, 1); myGPS.sendCfgValset8(CFG_MSGOUT_RTCM_3X_TYPE1230_I2C, 10);

Expected behavior

Changes saved to RAM + other layers

Actual behavior

Changes saved to BBR only

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixedIssue is fixed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions