Fix set_stream_options arguments

Author: lstrojny

src/VCR/Util/StreamProcessor.php

@@ -493,14 +493,14 @@ public function stream_lock(int $operation): bool
  *
  * @codeCoverageIgnore
  *
- * @param int $option one of STREAM_OPTION_BLOCKING, STREAM_OPTION_READ_TIMEOUT, STREAM_OPTION_WRITE_BUFFER
- * @param int $arg1 depending on option
- * @param int $arg2 depending on option
+ * @param int  $option one of STREAM_OPTION_BLOCKING, STREAM_OPTION_READ_TIMEOUT, STREAM_OPTION_WRITE_BUFFER
+ * @param int  $arg1 depending on option
+ * @param int|null $arg2 depending on option
  *
  * @return bool Returns TRUE on success or FALSE on failure. If option is not implemented,
  * FALSE should be returned.
  */
- public function stream_set_option(int $option, int $arg1, int $arg2): bool
+ public function stream_set_option(int $option, int $arg1, ?int $arg2 = null): bool
  {
  if (false === $this->resource) {
  return false;

tests/Unit/Util/StreamProcessorTest.php

@@ -27,6 +27,24 @@ public function testFlockWithFilePutContents(): void
  $this->assertEquals(\strlen($testData), $res);
  }
 
+ public function testSetStreamOptions(): void
+ {
+ $processor = new StreamProcessor();
+ $processor->intercept();
+
+ $handle = fopen('tests/fixtures/file_put_contents', 'w');
+
+ self::assertTrue(stream_set_blocking($handle, true));
+ self::assertFalse(stream_set_timeout($handle, 10));
+ self::assertFalse(stream_set_timeout($handle, 5, 2));
+ self::assertSame(-1, stream_set_write_buffer($handle, 0));
+ self::assertSame(0, stream_set_read_buffer($handle, 0));
+
+ fclose($handle);
+
+ $processor->restore();
+ }
+
  /**
  * @dataProvider streamOpenAppendFilterProvider
  */