Move the disabled property to specific interfaces #240
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR #193 changed the
disabledproperty onHTMLElementfromBooleantojs.UndefOr[Boolean].Actually, there is no
disabledproperty defined on theHTMLElementinterface:https://html.spec.whatwg.org/multipage/dom.html#htmlelement
This property is instead defined on specific sub-interfaces. So far I found 9 of them in the one-page specification for HTML:
This pull requests moves the
disabledproperty fromHTMLElementto the 7 sub-interfaces already present and reverts its type toBoolean.I stumbled upon this while trying to define a custom element (extending
HTMLElement) that required a customdisabledproperty. The compiler is falsely complaining that "variable disabled cannot override a mutable variable" even no such variable actually exists.