Skip to content

Replace wrap_str with validate_shape #6413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace wrap_str with validate_shape #6413

wants to merge 1 commit into from

Conversation

@camsteffen
Copy link
Contributor

@camsteffen camsteffen commented Dec 3, 2024

This ultimately re-uses Shape::exceeds_max_width_error more to be a tad DRYer.
@ytmimi
Copy link
Contributor

ytmimi commented Dec 3, 2024

Would it be simpler to have wrap_str return Result<String, ExceedsMaxWidthError>?
@camsteffen
Copy link
Contributor Author

camsteffen commented Dec 7, 2024

I like how borrowing makes it clear that the string isn't modified personally. But that would be a more conservative change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-reviewed

3 participants

@camsteffen @ytmimi @rustbot