-   Notifications  
You must be signed in to change notification settings  - Fork 13.9k
 
Open
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-needs-designThis issue needs exploration and design to see how and if we can fix/implement itThis issue needs exploration and design to see how and if we can fix/implement itT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
For example, a codegen test:
//@ needs-llvm-components: riscv64 //@ compile-flags: --target riscv64gc-unknown-linux-gnu #![crate_type = "lib"] #![no_std] #![no_core] #![feature(no_core, lang_items)] extern crate minicore; // CHECK: fail!riscv64 isn't a real LLVM component (only riscv). However, the test never errors; instead it always gets ignored. It seems pretty likely that there are at least a few in-tree tests that never get run because of a typo here.
It should be reasonably easy to keep a list of valid LLVM components and validate against that in compiletest.
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-needs-designThis issue needs exploration and design to see how and if we can fix/implement itThis issue needs exploration and design to see how and if we can fix/implement itT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)