Skip to content

New JSX PPX can't be compiled to JS successfully #3512

@phated

Description

@phated

I've been trying to update the https://reasonml.github.io/en/try.html tool for the new ReasonReact syntax and I've found that the JSX PPX cannot be compiled for the browser correctly.

The #if BS_COMPILER_IN_BROWSER then code is currently commented out but if I re-enable it, it still doesn't generate the correct output. I think the issue is that only the mapper.structure is being applied to the source code but not the mapper.expr, mapper.signature, or mapper.module_binding.

It doesn't seem like those can be applied in the same way as

let pstr = Parse.implementation lexer in let pstr = mapper.structure mapper pstr in Pprintast.structure Format.str_formatter pstr;

because the resulting ocaml_code is empty when I attempt it.

I'm more than happy to keep working on this but I'll need some direction because I've hit a dead-end.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions