test: enable skipped tests (microsoft#573)

Author: mxschmitt

playwright/__main__.py

@@ -22,8 +22,6 @@
 def main() -> None:
  driver_executable = compute_driver_executable()
  my_env = os.environ.copy()
- # VSCode's JavaScript Debug Terminal provides it but driver/pkg does not support it
- my_env.pop("NODE_OPTIONS", None)
  my_env["PW_CLI_TARGET_LANG"] = "python"
  subprocess.run([str(driver_executable), *sys.argv[1:]], env=my_env)
 

playwright/_impl/_transport.py

@@ -53,14 +53,9 @@ async def run(self) -> None:
  self._loop = asyncio.get_running_loop()
  self._stopped_future: asyncio.Future = asyncio.Future()
 
- driver_env = os.environ.copy()
- # VSCode's JavaScript Debug Terminal provides it but driver/pkg does not support it
- driver_env.pop("NODE_OPTIONS", None)
-
  proc = await asyncio.create_subprocess_exec(
  str(self._driver_executable),
  "run-driver",
- env=driver_env,
  stdin=asyncio.subprocess.PIPE,
  stdout=asyncio.subprocess.PIPE,
  stderr=_get_stderr_fileno(),

tests/async/test_launcher.py

@@ -41,7 +41,6 @@ async def test_browser_type_launch_should_throw_if_page_argument_is_passed(
  assert "can not specify page" in exc.value.message
 
 
-@pytest.mark.skip("currently disabled on upstream")
 async def test_browser_type_launch_should_reject_if_launched_browser_fails_immediately(
  browser_type, launch_arguments, assetdir
 ):
@@ -52,9 +51,6 @@ async def test_browser_type_launch_should_reject_if_launched_browser_fails_immed
  )
 
 
-@pytest.mark.skip(
- "does not return the expected error"
-) # TODO: hangs currently on the bots
 async def test_browser_type_launch_should_reject_if_executable_path_is_invalid(
  browser_type, launch_arguments
 ):

tests/async/test_page.py

@@ -313,7 +313,6 @@ async def test_expose_function(page, server):
  assert result == 36
 
 
-@pytest.mark.skip("todo mxschmitt")
 async def test_expose_function_should_throw_exception_in_page_context(page, server):
  def throw():
  raise Exception("WOOF WOOF")