Skip to content

feat: basic implements #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Feb 12, 2022
Merged

feat: basic implements #1

merged 25 commits into from
Feb 12, 2022

Conversation

@vagusX
Copy link
Member

@vagusX vagusX commented Feb 8, 2022 •
edited
Loading

TODO:

  • update readme
@vagusX vagusX requested a review from zombieJ February 8, 2022 12:16
@codecov
Copy link

codecov bot commented Feb 8, 2022 •
edited
Loading

Codecov Report

Merging #1 (c21a3bd) into master (c93e265) will increase coverage by 2.94%.
The diff coverage is 100.00%.

❗ Current head c21a3bd differs from pull request most recent head e7e0bd9. Consider uploading reports for the commit e7e0bd9 to get more accurate results

Impacted file tree graph

@@ Coverage Diff @@ ## master #1 +/- ## =========================================== + Coverage 97.05% 100.00% +2.94%  =========================================== Files 2 1 -1 Lines 34 66 +32 Branches 22 14 -8 =========================================== + Hits 33 66 +33  + Misses 1 0 -1
Impacted Files Coverage Δ
src/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91f157...e7e0bd9. Read the comment docs.
@vagusX vagusX marked this pull request as ready for review February 10, 2022 14:53
@vagusX vagusX requested a review from afc163 February 11, 2022 02:05
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
@zombieJ
Copy link
Member

zombieJ commented Feb 11, 2022

加一下 preview https://github.com/afc163/surge-preview
@github-actions
Copy link

github-actions bot commented Feb 11, 2022 •
edited
Loading

🎊 PR Preview e7e0bd9 has been successfully built and deployed to https://react-component-segmented-preview-pr-1.surge.sh

🕐 Build time: 191.126s

🤖 By surge-preview
afc163
afc163 reviewed Feb 11, 2022
View reviewed changes
afc163
afc163 reviewed Feb 11, 2022
View reviewed changes
afc163
afc163 reviewed Feb 11, 2022
View reviewed changes
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
src/index.tsx Outdated
function isLabledOption(
option: RawOption | LabeledOption,
): option is LabeledOption {
return option === Object(option);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好 old school ...
(just comment. No need to change~)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeof 不够严谨
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
zombieJ
zombieJ reviewed Feb 11, 2022
View reviewed changes
@vagusX vagusX merged commit c8be6d5 into master Feb 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev branch February 12, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@vagusX @zombieJ @afc163