Normalize resetting schema cache version for YAML and Marshal #38564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When dumping the schema cache, we first call clear! which resets everything, including setting the @Version to nil. Dumping with YAML dumps the correct version, but doesn't actually update the instance variable. Dumping with Marshal writes the variable. This change makes it more consistent between the two strategies. Also, for codebases that use an alternate versioning strategy, they only need to overwrite reset_version! rather than overwriting the serialization method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Extract a method to reset the schema cache to make serialization more consistent between YAML and Marshal.
Summary
When dumping the schema cache, we first call clear! which resets
everything, including setting the @Version to nil.
Dumping with YAML dumps the correct version, but doesn't actually
update the instance variable.
Dumping with Marshal writes the variable.
This change makes it more consistent between the two strategies.
Also, for codebases (such as GitHub) that use an alternate versioning strategy for the schema cache, they only need to overwrite reset_version! rather than overwriting the serialization method.