Skip to content

Conversation

@metalcycling
Copy link
Collaborator

Issue link

Fixes #516

What changes have been made

  • Hardcoded the port number to be used when starting a local kubeproxy in the end 2 end script.

Verification steps

Ran the script on my local development machine.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change
@metalcycling metalcycling requested a review from asm582 July 27, 2023 16:07
@openshift-ci openshift-ci bot requested review from dimakis and z103cb July 27, 2023 16:08
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from metalcycling. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@asm582 asm582 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @metalcycling on Webex, LGTM

@asm582 asm582 merged commit 9d3cb97 into project-codeflare:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants