Skip to content

Conversation

@asm582
Copy link
Member

@asm582 asm582 commented Jul 18, 2023

No description provided.

@atantawi
Copy link
Collaborator

  • allocResponse.GetPreemptedIds() returns a list of consumer IDs that need be preempted for a requesting consumerID to get its quota demand.

  • allocResponse.GetConsumerID() returns the requesting consumerID.

  • If the list of preempted IDs is empty, I don't understand why would you want to add consumerID to the list of preempted AppWrappers.

@asm582
Copy link
Member Author

asm582 commented Jul 18, 2023

  • allocResponse.GetPreemptedIds() returns a list of consumer IDs that need be preempted for a requesting consumerID to get its quota demand.
  • allocResponse.GetConsumerID() returns the requesting consumerID.
  • If the list of preempted IDs is empty, I don't understand why would you want to add consumerID to the list of preempted AppWrappers.

@atantawi Sure, here is a scenario, When the cluster is full of low-priority AWs and when one high-priority AW comes in we see that allocResponse.GetConsumerID() contains the candidate low-priority AW that will be preempted but allocResponse.GetPreemptedIds() is empty which does not cause preemption of low-priority AW

@atantawi
Copy link
Collaborator

Thanks for the clarification. I'll examine.

@asm582
Copy link
Member Author

asm582 commented Aug 11, 2023

QM manager library has gone through redesign, I am closing this PR

@metalcycling @atantawi

@asm582 asm582 closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants