Skip to content

Conversation

Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good.
Can you attach a log of make push-images ?

@Srihari1192
Copy link
Contributor Author

This look good. Can you attach a log of make push-images ?

Applied the same changes in upstream dummy branch to test as i have no permission to create branch in upstream.. Build runs here https://app.travis-ci.com/github/project-codeflare/multi-cluster-app-dispatcher/builds/264331841

Tested against private repository looks good https://quay.io/repository/svenkata1/test-mcad?tab=tags

Logs:
make push-images quay_repository=quay.io/svenkata1/test-mcad quay_id=svenkata1 quay_token=$QUAY_TOKEN TAG=v1.3.0 GIT_BRANCH=v1.3.0 "---" "MAKE GLOBAL VARIABLES:" " "BIN_DIR="_output/bin" " "GIT_BRANCH="v1.3.0" " "RELEASE_VER="v1.3.0" " "TAG="v1.3.0" " "GO_BUILD_ARGS="" "---" Check for invalid tag name t=v1.3.0 && [ ${#t} -le 128 ] || { echo "Target name $t has 128 or more chars"; false; } Log into quay Tag the latest image Push the docker image to registry docker login quay.io Login Succeeded docker tag mcad-controller:v1.3.0 quay.io/svenkata1/test-mcad:v1.3.0 docker push quay.io/svenkata1/test-mcad:v1.3.0 The push refers to repository [quay.io/svenkata1/test-mcad] 7aeee2b59cfe: Layer already exists 5f70bf18a086: Layer already exists eec483e2dc9a: Layer already exists 7f25c26c77bc: Layer already exists 1ce8f4152f4d: Layer already exists a7192762d366: Layer already exists v1.3.0: digest: sha256:f6f541a025144d1d8922d05cb798f595c2dcabf8e6911372b5ffff7ded1b7585 size: 1582

Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs look good to me as well

@z103cb
Copy link
Contributor

z103cb commented Jul 6, 2023

Yes, they do look good.

@z103cb z103cb merged commit ef10f5a into project-codeflare:main Jul 6, 2023
@Srihari1192 Srihari1192 deleted the fix-CIfailure branch July 7, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants