Skip to content

Conversation

@Srihari1192
Copy link
Contributor

Fixes #394

@sutaakar
Copy link
Contributor

sutaakar commented Jun 7, 2023

@Srihari1192 Could you add also creating a release on https://pkg.go.dev/github.com/project-codeflare/multi-cluster-app-dispatcher ? That release could be then leveraged in InstaScale as it depends on MCAD.

Edit: The release could be published automatically, needs to be checked once MCAD release is published on GitHub.

z103cb
z103cb previously approved these changes Jun 13, 2023
asm582
asm582 previously approved these changes Jun 13, 2023
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, and then we can merge.

@Srihari1192 Srihari1192 dismissed stale reviews from asm582 and z103cb via 073c695 June 14, 2023 06:00
@Srihari1192 Srihari1192 requested a review from anishasthana June 14, 2023 06:00
@Srihari1192
Copy link
Contributor Author

@anishasthana can you review and merge this

@anishasthana anishasthana merged commit 9035cd7 into project-codeflare:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants