Update TAG Generation Logic #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Maxusmusti reviewed Jun 6, 2023
The Tag generation logic currently results in the image having a tag like the following: release-v1.30.0-v.1.30.0 This is as we use both the release branch name and the tag name. What we have previously done to get around this is manually edit the tags once pushed up to Quay. This commit introduces a change such that the generated tag matches the release branch exactly. Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Tag generation logic currently results in the image having a tag like the following:
release-v1.30.0-v.1.30.0
This is as we use both the release branch name and the tag name. What we have previously done to get around this is manually edit the tags once pushed up to Quay. This commit introduces a change such that the generated tag matches the release branch exactly. I think this can be a precursor to us getting rid of the VERSION file altogether.
cc @Maxusmusti