Skip to content

Error handling updates in quota management usage #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 26, 2023
Merged

Error handling updates in quota management usage #367

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
847b0b9
Small error handling updates.
z103cb May 15, 2023
5ebd199
Small formatting updates
z103cb May 15, 2023
38b5144
Updates to the gitignore.
z103cb May 15, 2023
f25812c
Merge branch 'main' into hotfix_qm_build
z103cb May 16, 2023
3d82520
Changes to allow for quota trees to present
z103cb May 17, 2023
e287f1d
Addressed PR comment.
z103cb May 17, 2023
d816fb5
Merge branch 'hotfix_qm_build' into fix-qm-tests
z103cb May 17, 2023
8caa3ae
Fixed issues with correct interpretation of quanty
z103cb May 17, 2023
5ee871e
Cleanup e2e script.
z103cb May 17, 2023
37fdd3a
Changed regex for quota specification
z103cb May 18, 2023
eb3a0e9
Fixed error in qm backend struct
z103cb May 19, 2023
4d29d6c
Fixed test case error
z103cb May 19, 2023
80d1e58
First pass at fixing the concurency issues
z103cb May 25, 2023
986ac60
Added explicit quota release steps for errors in ScheduleNext
z103cb May 26, 2023
cf60966
Added sleep to allow for the test namespace to be cleaned up.
z103cb May 26, 2023
b32182c
Small changes to unit test
z103cb May 26, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Small changes to unit test
  • Loading branch information
@z103cb
z103cb committed May 26, 2023
commit b32182ce790f31affd79246cd635e3f24e4c899f
3 changes: 2 additions & 1 deletion pkg/quotaplugins/quota-forest/quota-manager/quota/quotamanager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ func TestNewQuotaManagerConsumerAllocationRelease(t *testing.T) {
assert.NoError(t, err, "No error expected when adding a tree to forest")
err = qmManagerUnderTest.AddTreeToForest(forestName, testTreeName)
assert.NoError(t, err, "No error expected when adding a tree from forest")
qmManagerUnderTest.SetMode(quota.Normal)
modeSet := qmManagerUnderTest.SetMode(quota.Normal)
assert.True(t, modeSet, "Setting the mode should not fail.")

// Define the test table
var tests = []struct {
Expand Down