Skip to content

Commit 26d631b

Browse files
committed
Update TAG Generation Logic
The Tag generation logic currently results in the image having a tag like the following: release-v1.30.0-v.1.30.0 This is as we use both the release branch name and the tag name. What we have previously done to get around this is manually edit the tags once pushed up to Quay. This commit introduces a change such that the generated tag matches the release branch exactly. Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
1 parent 14d569b commit 26d631b

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

Makefile

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,12 @@ ifneq ($(strip $(GIT_BRANCH)),)
2525
# replace invalid characters that might exist in the branch name
2626
TAG:=$(shell echo ${TAG} | sed 's/[^a-zA-Z0-9]/-/g')
2727
endif
28-
TAG:=${TAG}${RELEASE_VER}
28+
29+
# Check if the string contains "release"
30+
ifneq (,$(findstring release,$(GIT_BRANCH)))
31+
else
32+
TAG:=${TAG}${RELEASE_VER}
33+
endif
2934

3035
.PHONY: print-global-variables
3136

0 commit comments

Comments
 (0)