Skip to content

Commit e9d5a6f

Browse files
authored
Merge pull request PHP-DI#889 from staudenmeir/php8.4
Prepare for PHP 8.4
2 parents eaf007e + 3e3b866 commit e9d5a6f

17 files changed

+22
-22
lines changed

.php-cs-fixer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
'php_unit_method_casing' => false,
5858
'blank_line_between_import_groups' => false,
5959
'global_namespace_import' => false,
60-
'nullable_type_declaration_for_default_null_value' => false,
60+
'nullable_type_declaration_for_default_null_value' => true,
6161
])
6262
->setRiskyAllowed(true)
6363
->setFinder($finder);

src/Container.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ public static function create(
8989
*/
9090
public function __construct(
9191
array|MutableDefinitionSource $definitions = [],
92-
ProxyFactory $proxyFactory = null,
93-
ContainerInterface $wrapperContainer = null
92+
?ProxyFactory $proxyFactory = null,
93+
?ContainerInterface $wrapperContainer = null
9494
) {
9595
if (is_array($definitions)) {
9696
$this->definitionSource = $this->createDefaultDefinitionSource($definitions);

src/ContainerBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ public function useAttributes(bool $bool) : self
238238
* @return $this
239239
* @throws InvalidArgumentException when writeToFile is set to true and the proxy directory is null
240240
*/
241-
public function writeProxiesToFile(bool $writeToFile, string $proxyDirectory = null) : self
241+
public function writeProxiesToFile(bool $writeToFile, ?string $proxyDirectory = null) : self
242242
{
243243
$this->ensureNotLocked();
244244

src/Definition/Exception/InvalidDefinition.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
*/
1515
class InvalidDefinition extends \Exception implements ContainerExceptionInterface
1616
{
17-
public static function create(Definition $definition, string $message, \Exception $previous = null) : self
17+
public static function create(Definition $definition, string $message, ?\Exception $previous = null) : self
1818
{
1919
return new self(sprintf(
2020
'%s' . \PHP_EOL . 'Full definition:' . \PHP_EOL . '%s',

src/Definition/Helper/CreateDefinitionHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class CreateDefinitionHelper implements DefinitionHelper
4343
* @param string|null $className Class name of the object.
4444
* If null, the name of the entry (in the container) will be used as class name.
4545
*/
46-
public function __construct(string $className = null)
46+
public function __construct(?string $className = null)
4747
{
4848
$this->className = $className;
4949
}

src/Definition/ObjectDefinition.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class ObjectDefinition implements Definition
5252
/**
5353
* @param string $name Entry name
5454
*/
55-
public function __construct(string $name, string $className = null)
55+
public function __construct(string $name, ?string $className = null)
5656
{
5757
$this->name = $name;
5858
$this->setClassName($className);
@@ -159,7 +159,7 @@ public function completeFirstMethodInjection(MethodInjection $injection) : void
159159
}
160160
}
161161

162-
public function setLazy(bool $lazy = null) : void
162+
public function setLazy(?bool $lazy = null) : void
163163
{
164164
$this->lazy = $lazy;
165165
}

src/Definition/ObjectDefinition/PropertyInjection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class PropertyInjection
2929
* @param string $propertyName Property name
3030
* @param mixed $value Value that should be injected in the property
3131
*/
32-
public function __construct(string $propertyName, mixed $value, string $className = null)
32+
public function __construct(string $propertyName, mixed $value, ?string $className = null)
3333
{
3434
$this->propertyName = $propertyName;
3535
$this->value = $value;

src/Definition/Resolver/ParameterResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ public function __construct(
3131
* @throws InvalidDefinition A parameter has no value defined or guessable.
3232
*/
3333
public function resolveParameters(
34-
MethodInjection $definition = null,
35-
ReflectionMethod $method = null,
34+
?MethodInjection $definition = null,
35+
?ReflectionMethod $method = null,
3636
array $parameters = [],
3737
) : array {
3838
$args = [];

src/Definition/Source/AttributeBasedAutowiring.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class AttributeBasedAutowiring implements DefinitionSource, Autowiring
3131
/**
3232
* @throws InvalidAttribute
3333
*/
34-
public function autowire(string $name, ObjectDefinition $definition = null) : ObjectDefinition|null
34+
public function autowire(string $name, ?ObjectDefinition $definition = null) : ObjectDefinition|null
3535
{
3636
$className = $definition ? $definition->getClassName() : $name;
3737

@@ -92,7 +92,7 @@ private function readProperties(ReflectionClass $class, ObjectDefinition $defini
9292
/**
9393
* @throws InvalidAttribute
9494
*/
95-
private function readProperty(ReflectionProperty $property, ObjectDefinition $definition, string $classname = null) : void
95+
private function readProperty(ReflectionProperty $property, ObjectDefinition $definition, ?string $classname = null) : void
9696
{
9797
if ($property->isStatic() || $property->isPromoted()) {
9898
return;

src/Definition/Source/Autowiring.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ interface Autowiring
1919
*
2020
* @throws InvalidDefinition An invalid definition was found.
2121
*/
22-
public function autowire(string $name, ObjectDefinition $definition = null) : ObjectDefinition|null;
22+
public function autowire(string $name, ?ObjectDefinition $definition = null) : ObjectDefinition|null;
2323
}

0 commit comments

Comments
 (0)