Don't inject promoted properties

Author: apeschar

src/Definition/Source/AttributeBasedAutowiring.php

@@ -77,19 +77,13 @@ public function getDefinitions() : array
  private function readProperties(ReflectionClass $class, ObjectDefinition $definition) : void
  {
  foreach ($class->getProperties() as $property) {
- if ($property->isStatic()) {
- continue;
- }
  $this->readProperty($property, $definition);
  }
 
  // Read also the *private* properties of the parent classes
  /** @noinspection PhpAssignmentInConditionInspection */
  while ($class = $class->getParentClass()) {
  foreach ($class->getProperties(ReflectionProperty::IS_PRIVATE) as $property) {
- if ($property->isStatic()) {
- continue;
- }
  $this->readProperty($property, $definition, $class->getName());
  }
  }
@@ -100,6 +94,10 @@ private function readProperties(ReflectionClass $class, ObjectDefinition $defini
  */
  private function readProperty(ReflectionProperty $property, ObjectDefinition $definition, string $classname = null) : void
  {
+ if ($property->isStatic() || $property->isPromoted()) {
+ return;
+ }
+
  // Look for #[Inject] attribute
  try {
  $attribute = $property->getAttributes(Inject::class)[0] ?? null;

tests/UnitTest/Definition/Source/AttributeBasedAutowiringTest.php

@@ -20,6 +20,7 @@
 use DI\Test\UnitTest\Definition\Source\Fixtures\AnnotationFixtureTypedProperties;
 use DI\Test\UnitTest\Definition\Source\Fixtures\AnnotationInjectableFixture;
 use DI\Test\UnitTest\Definition\Source\Fixtures\AttributeFixture;
+use DI\Test\UnitTest\Definition\Source\Fixtures\AttributeFixturePromotedProperty;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -242,6 +243,19 @@ public function testReadParentPrivateProperties()
  $this->assertHasPropertyInjection($definition, 'propertyParentPrivate');
  }
 
+ public function testPromotedProperties(): void
+ {
+ $definition = (new AttributeBasedAutowiring)->autowire(AttributeFixturePromotedProperty::class);
+ $this->assertNotHasPropertyInjection($definition, 'promotedProperty');
+
+ $constructorInjection = $definition->getConstructorInjection();
+ $this->assertInstanceOf(MethodInjection::class, $constructorInjection);
+
+ $parameters = $constructorInjection->getParameters();
+ $this->assertCount(1, $parameters);
+ $this->assertEquals(new Reference('foo'), $parameters[0]);
+ }
+
  private function getMethodInjection(ObjectDefinition $definition, $name) : ?MethodInjection
  {
  $methodInjections = $definition->getMethodInjections();
@@ -279,7 +293,7 @@ private function assertNotHasPropertyInjection(ObjectDefinition $definition, $pr
  $propertyInjections = $definition->getPropertyInjections();
  foreach ($propertyInjections as $propertyInjection) {
  if ($propertyInjection->getPropertyName() === $propertyName) {
- $this->fail('No property injection found for ' . $propertyName);
+ $this->fail('Unexpected property injection found for ' . $propertyName);
  }
  }
  }

tests/UnitTest/Definition/Source/Fixtures/AttributeFixturePromotedProperty.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DI\Test\UnitTest\Definition\Source\Fixtures;
+
+use DI\Attribute\Inject;
+
+class AttributeFixturePromotedProperty
+{
+ public function __construct(#[Inject("foo")] public $promotedProperty) {
+ }
+}