Remove deprecated FromBytes in favor of OpenBytes

Author: oschwald

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changes
 
+## 2.0.0 - 2025-10-18
+
+- BREAKING CHANGE: Removed deprecated `FromBytes`. Use `OpenBytes` instead.
+
 ## 2.0.0-beta.10 - 2025-08-23
 
 - Replaced `runtime.SetFinalizer` with `runtime.AddCleanup` for resource

fuzz_test.go

@@ -29,7 +29,7 @@ func FuzzDatabase(f *testing.F) {
 f.Add([]byte{})
 
 f.Fuzz(func(_ *testing.T, data []byte) {
-reader, err := FromBytes(data)
+reader, err := OpenBytes(data)
 if err != nil {
 return
 }
@@ -74,7 +74,7 @@ func FuzzLookup(f *testing.F) {
 }
 
 f.Fuzz(func(_ *testing.T, data []byte) {
-reader, err := FromBytes(data)
+reader, err := OpenBytes(data)
 if err != nil {
 return
 }
@@ -225,7 +225,7 @@ func FuzzNetworks(f *testing.F) {
 f.Add(bytes.Repeat([]byte{0xFF}, 512))
 
 f.Fuzz(func(_ *testing.T, data []byte) {
-reader, err := FromBytes(data)
+reader, err := OpenBytes(data)
 if err != nil {
 return
 }

reader.go

@@ -366,14 +366,6 @@ func OpenBytes(buffer []byte, options ...ReaderOption) (*Reader, error) {
 return reader, nil
 }
 
-// FromBytes takes a byte slice corresponding to a MaxMind DB file and any
-// options. It returns a Reader structure or an error.
-//
-// Deprecated: Use OpenBytes instead. FromBytes will be removed in a future version.
-func FromBytes(buffer []byte, options ...ReaderOption) (*Reader, error) {
-return OpenBytes(buffer, options...)
-}
-
 // Lookup retrieves the database record for ip and returns a Result, which can
 // be used to decode the data.
 func (r *Reader) Lookup(ip netip.Addr) Result {

reader_test.go

@@ -53,7 +53,7 @@ func TestReaderBytes(t *testing.T) {
 )
 bytes, err := os.ReadFile(fileName)
 require.NoError(t, err)
-reader, err := FromBytes(bytes)
+reader, err := OpenBytes(bytes)
 require.NoError(t, err, "unexpected error while opening bytes: %v", err)
 
 checkMetadata(t, reader, ipVersion, recordSize)
@@ -1260,7 +1260,7 @@ func TestMetadataBuildTime(t *testing.T) {
 }
 
 func TestIntegerOverflowProtection(t *testing.T) {
-// Test that FromBytes detects integer overflow in search tree size calculation
+// Test that OpenBytes detects integer overflow in search tree size calculation
 t.Run("NodeCount overflow protection", func(t *testing.T) {
 // Create metadata that would cause overflow: very large NodeCount
 // For a 64-bit system with RecordSize=32, this should trigger overflow
@@ -1289,14 +1289,14 @@ func TestIntegerOverflowProtection(t *testing.T) {
 
 // Since we can't easily create an invalid MMDB file that parses but has overflow values,
 // we test the core logic validation here and rely on integration tests
-// for the full FromBytes flow
+// for the full OpenBytes flow
 
 if metadata.NodeCount > 0 && metadata.RecordSize > 0 {
 recordSizeQuarter := metadata.RecordSize / 4
 if recordSizeQuarter > 0 {
 maxNodes := ^uint(0) / recordSizeQuarter
 if metadata.NodeCount > maxNodes {
-// This is what should happen in FromBytes
+// This is what should happen in OpenBytes
 err := mmdberrors.NewInvalidDatabaseError("database tree size would overflow")
 assert.Equal(t, "database tree size would overflow", err.Error())
 }