cleanup & comments

Author: VipulMascarenhas

ads/aqua/deployment.py

@@ -25,7 +25,7 @@ class AquaDeployment:
 
  display_name: str
  aqua_service_model: str
- status: str
+ state: str
  description: str
  created_on: str
  created_by: str
@@ -153,7 +153,6 @@ def create(
  log_id=predict_log_id,
  )
  )
- logger.info(f"Infra: {infrastructure}")
  # configure model deployment runtime
  # todo : any other runtime params needed?
  container_runtime = (
@@ -169,7 +168,6 @@ def create(
  .with_overwrite_existing_artifact(False)
  .with_remove_existing_artifact(False)
  )
- logger.info(f"Infra: {container_runtime}")
  # configure model deployment and deploy model on container runtime
  # todo : any other deployment params needed?
  deployment = (
@@ -184,7 +182,7 @@ def create(
  return AquaDeployment(
  display_name=deployment.display_name,
  aqua_service_model=aqua_service_model,
- status=deployment.status.name,
+ state=deployment.status.name,
  description=deployment.description,
  created_on=deployment.time_created,
  created_by=deployment.created_by,

ads/aqua/extension/base_handler.py

@@ -42,6 +42,7 @@ def finish(self, payload=None): # pylint: disable=W0221
  return super().finish(payload)
 
 
+# todo: remove after error handler is implemented
 class Errors(str):
  INVALID_INPUT_DATA_FORMAT = "Invalid format of input data."
  NO_INPUT_DATA = "No input data provided."

ads/aqua/extension/deployment_handler.py

@@ -87,7 +87,7 @@ def post(self, *args, **kwargs):
  400, Errors.MISSING_REQUIRED_PARAMETER.format("predict_log_id")
  )
 
- # todo: remove this & replace with id from aqua model
+ # todo: remove this & replace with id from aqua model once AquaModelApp.create() is implemented
  model_id = input_data.get("model_id")
  if not instance_count:
  raise HTTPError(400, Errors.MISSING_REQUIRED_PARAMETER.format("model_id"))
@@ -99,10 +99,11 @@ def post(self, *args, **kwargs):
  try:
  # todo: call create method to create a catalog entry
  # aqua_model = AquaModelApp.create()
- # get deployment_image from aqua model
+ # todo: hardcoded image, get deployment_image and aqua_service_model tag from aqua model?
+ # Also, entrypoint would be added in the image
  deployment_image = "iad.ocir.io/ociodscdev/aqua_deploy:1.0.0"
  entrypoint = ["python", "/opt/api/api.py"]
- aqua_service_model = f"xxx.xxx.xxx.xxx.xxx#Mistral-7B-Instruct-v0.1"
+ aqua_service_model = f"xxx.xxx.xxx.xxx.xxx#aqua_service_model_value"
 
  self.finish(
  AquaDeploymentApp().create(