Make checkbox keywords not to work with radio buttons (robotframework#964)

* Better error if element with certain type not found. Also changed type names to more human readable format. Make checkbox keywords not to work with radio buttons Fixes robotframework#962.

Author: pekkaklarck

src/SeleniumLibrary/keywords/element.py

@@ -593,15 +593,15 @@ def click_link(self, locator):
  link text.
  """
  self.info("Clicking link '%s'." % locator)
- self.find_element(locator, tag='a').click()
+ self.find_element(locator, tag='link').click()
 
  @keyword
  def get_all_links(self):
  """Returns a list containing ids of all links found in current page.
 
  If a link has no id, an empty string will be in the list instead.
  """
- links = self.find_elements("tag=a", tag='a')
+ links = self.find_elements("tag=a")
  return [link.get_attribute('id') for link in links]
 
  @keyword
@@ -612,7 +612,7 @@ def mouse_down_on_link(self, locator):
  syntax. Key attributes for links are ``id``, ``name``, ``href`` and
  link text.
  """
- element = self.find_element(locator, tag='a')
+ element = self.find_element(locator, tag='link')
  action = ActionChains(self.browser)
  action.click_and_hold(element).perform()
 

src/SeleniumLibrary/keywords/formelement.py

@@ -367,7 +367,7 @@ def _get_value(self, locator, tag):
  return self.find_element(locator, tag).get_attribute('value')
 
  def _get_checkbox(self, locator):
- return self.find_element(locator, tag='input')
+ return self.find_element(locator, tag='checkbox')
 
  def _get_radio_buttons(self, group_name):
  xpath = "xpath://input[@type='radio' and @name='%s']" % group_name

src/SeleniumLibrary/keywords/selectelement.py

@@ -395,7 +395,7 @@ def _get_labels_for_options(self, options):
  return labels
 
  def _get_select_list(self, locator):
- el = self.find_element(locator, tag='select')
+ el = self.find_element(locator, tag='list')
  return Select(el)
 
  def _get_select_list_options(self, select_list_or_locator):

src/SeleniumLibrary/locators/elementfinder.py

@@ -60,6 +60,7 @@ def __init__(self, ctx):
 
  def find(self, locator, tag=None, first_only=True, required=True,
  parent=None):
+ element_type = 'Element' if not tag else tag.capitalize()
  if parent and not self._is_webelement(parent):
  raise ValueError('Parent must be Selenium WebElement but it '
  'was {}'.format(type(parent)))
@@ -71,8 +72,8 @@ def find(self, locator, tag=None, first_only=True, required=True,
  elements = strategy(criteria, tag, constraints,
  parent=parent or self.browser)
  if required and not elements:
- raise ElementNotFound("Element with locator '{}' not found."
- .format(locator))
+ raise ElementNotFound("{} with locator '{}' not found."
+ .format(element_type, locator))
  if first_only:
  if not elements:
  return None

test/acceptance/keywords/checkbox_and_radio_buttons.robot

@@ -32,6 +32,24 @@ UnSelect Checkbox
  Unselect Checkbox can_send_email
  Checkbox Should Not Be Selected can_send_email
 
+Checkbox keywords don't work with radio buttons
+ Run Keyword And Expect Error
+ ... Page should have contained checkbox 'referrer' but did not.
+ ... Page Should Contain Checkbox referrer
+ Page Should Not Contain Checkbox referrer
+ Run Keyword And Expect Error
+ ... Checkbox with locator 'referrer' not found.
+ ... Checkbox Should Be Selected referrer
+ Run Keyword And Expect Error
+ ... Checkbox with locator 'referrer' not found.
+ ... Checkbox Should Not Be Selected referrer
+ Run Keyword And Expect Error
+ ... Checkbox with locator 'referrer' not found.
+ ... Select Checkbox referrer
+ Run Keyword And Expect Error
+ ... Checkbox with locator 'referrer' not found.
+ ... Unselect Checkbox referrer
+
 Radio Button Should Be Set To
  [Documentation] LOG 2 Verifying radio button 'sex' has selection 'female'.
  Radio Button Should Be Set To sex female
@@ -65,3 +83,11 @@ Radio button not found
  Run Keyword And Expect Error
  ... No radio button with name 'nonex' found.
  ... Radio button should be set to nonex whatever
+
+Radio button keywords don't work with checkboxes
+ Run Keyword And Expect Error
+ ... No radio button with name 'can_send_email' and value 'whatever' found.
+ ... Select Radio Button can_send_email whatever
+ Run Keyword And Expect Error
+ ... No radio button with name 'can_send_email' found.
+ ... Radio button should be set to can_send_email whatever