Skip to content

Commit 6c01a5a

Browse files
authored
Reduce amount of code (android10#106)
1 parent 0bbc1aa commit 6c01a5a

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieDetailsActivity.kt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,10 @@ class MovieDetailsActivity : BaseActivity() {
2424
companion object {
2525
private const val INTENT_EXTRA_PARAM_MOVIE = "com.fernandocejas.INTENT_PARAM_MOVIE"
2626

27-
fun callingIntent(context: Context, movie: MovieView): Intent {
28-
val intent = Intent(context, MovieDetailsActivity::class.java)
29-
intent.putExtra(INTENT_EXTRA_PARAM_MOVIE, movie)
30-
return intent
31-
}
27+
fun callingIntent(context: Context, movie: MovieView) =
28+
Intent(context, MovieDetailsActivity::class.java).apply {
29+
putExtra(INTENT_EXTRA_PARAM_MOVIE, movie)
30+
}
3231
}
3332

3433
override fun fragment() = MovieDetailsFragment.forMovie(intent.getParcelableExtra(INTENT_EXTRA_PARAM_MOVIE))

app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieDetailsFragment.kt

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ package com.fernandocejas.sample.features.movies
1717

1818
import android.os.Bundle
1919
import android.view.View
20+
import androidx.core.os.bundleOf
2021
import com.fernandocejas.sample.core.platform.BaseFragment
2122
import com.fernandocejas.sample.R
2223
import com.fernandocejas.sample.features.movies.MovieFailure.NonExistentMovie
@@ -46,14 +47,8 @@ class MovieDetailsFragment : BaseFragment() {
4647
companion object {
4748
private const val PARAM_MOVIE = "param_movie"
4849

49-
fun forMovie(movie: MovieView?): MovieDetailsFragment {
50-
val movieDetailsFragment = MovieDetailsFragment()
51-
movie?.let {
52-
val arguments = Bundle()
53-
arguments.putParcelable(PARAM_MOVIE, it)
54-
movieDetailsFragment.arguments = arguments
55-
}
56-
return movieDetailsFragment
50+
fun forMovie(movie: MovieView?) = MovieDetailsFragment().apply {
51+
arguments = bundleOf(PARAM_MOVIE to movie)
5752
}
5853
}
5954

0 commit comments

Comments
 (0)