Fixed an "AssertionError: ensure_dir_exists" when checking library updates from simultaneous subprocesses // Resolve platformio#3677

Author: ivankravets

HISTORY.rst

@@ -14,6 +14,7 @@ PlatformIO Core 5
 - Fixed a "PermissionError: [WinError 5]" on Windows when external repository is used with `lib_deps <https://docs.platformio.org/page/projectconf/section_env_library.html#lib-deps>`__ option (`issue #3664 <https://github.com/platformio/platformio-core/issues/3664>`_)
 - Fixed a "KeyError: 'versions'" when dependency does not exist in the registry (`issue #3666 <https://github.com/platformio/platformio-core/issues/3666>`_)
 - Fixed an issue with GCC linker when "native" dev-platform is used in pair with library dependencies (`issue #3669 <https://github.com/platformio/platformio-core/issues/3669>`_)
+- Fixed an "AssertionError: ensure_dir_exists" when checking library updates from simultaneous subprocesses (`issue #3677 <https://github.com/platformio/platformio-core/issues/3677>`_)
 
 5.0.1 (2020-09-10)
 ~~~~~~~~~~~~~~~~~~

platformio/package/manager/base.py

@@ -51,7 +51,7 @@ class BasePackageManager( # pylint: disable=too-many-public-methods
 
  def __init__(self, pkg_type, package_dir):
  self.pkg_type = pkg_type
- self.package_dir = self.ensure_dir_exists(package_dir)
+ self.package_dir = package_dir
  self._MEMORY_CACHE = {}
 
  self._lockfile = None
@@ -62,7 +62,9 @@ def __init__(self, pkg_type, package_dir):
  def lock(self):
  if self._lockfile:
  return
+ self.ensure_dir_exists(os.path.dirname(self.package_dir))
  self._lockfile = LockFile(self.package_dir)
+ self.ensure_dir_exists(self.package_dir)
  self._lockfile.acquire()
 
  def unlock(self):
@@ -91,10 +93,7 @@ def is_system_compatible(value):
  @staticmethod
  def ensure_dir_exists(path):
  if not os.path.isdir(path):
- try:
- os.makedirs(path)
- except: # pylint: disable=bare-except
- pass
+ os.makedirs(path)
  assert os.path.isdir(path)
  return path
 
@@ -193,6 +192,9 @@ def build_metadata(self, pkg_dir, spec, vcs_revision=None):
  return metadata
 
  def get_installed(self):
+ if not os.path.isdir(self.package_dir):
+ return []
+
  cache_key = "get_installed"
  if self.memcache_get(cache_key):
  return self.memcache_get(cache_key)