Merge pull request magento#134 from magento-commerce/MQE-2669_alex

MQE-2669: Seprated a run:failed command to generate:failed and run:fa…

Author: okolesnyk

dev/tests/unit/Magento/FunctionalTestFramework/Console/RunTestFailedCommandTest.php

@@ -0,0 +1,53 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace tests\unit\Magento\FunctionalTestFramework\Console;
+
+use Magento\FunctionalTestingFramework\Console\RunTestFailedCommand;
+
+class RunTestFailedCommandTest extends BaseGenerateCommandTest
+{
+ /**
+ * @throws \ReflectionException
+ */
+ public function testMultipleTests(): void
+ {
+ $testFailedFile = [
+ "tests/functional/tests/MFTF/_generated/default/SingleTestNoSuiteTest.php:SingleTestNoSuiteTest",
+ "tests/functional/tests/MFTF/_generated/SomeSpecificSuite/FirstTestSuiteTest.php:SingleTestSuiteTest",
+ "tests/functional/tests/MFTF/_generated/SomeSpecificSuite/SecondTestNoSuiteTest.php:SingleTestNoSuiteTest",
+ "tests/functional/tests/MFTF/_generated/SomeOtherSuite/SecondTestNoSuiteTest.php:SingleTestNoSuiteTest",
+ ];
+
+ $expectedResult = [
+ "tests/functional/tests/MFTF/_generated/default/SingleTestNoSuiteTest.php",
+ "-g SomeSpecificSuite",
+ "-g SomeOtherSuite",
+ ];
+
+ $runFailed = new RunTestFailedCommand('run:failed');
+ $filter = $this->invokePrivateMethod($runFailed, 'filterTestsForExecution', [$testFailedFile]);
+ $this->assertEquals($expectedResult, $filter);
+ }
+
+ /**
+ * Invoking private method to be able to test it.
+ * NOTE: Bad practice don't repeat it.
+ *
+ * @param $object
+ * @param $methodName
+ * @param array $parameters
+ * @return mixed
+ * @throws \ReflectionException
+ */
+ private function invokePrivateMethod(&$object, $methodName, array $parameters = [])
+ {
+ $reflection = new \ReflectionClass(get_class($object));
+ $method = $reflection->getMethod($methodName);
+ $method->setAccessible(true);
+ return $method->invokeArgs($object, $parameters);
+ }
+}

dev/tests/verification/Resources/ActionGroupContainsStepKeyInArgText.txt

@@ -41,4 +41,10 @@ class ActionGroupContainsStepKeyInArgTextCest
 $I->see("arg1", ".selector"); // stepKey: arg1ActionGroup
 $I->comment("Exiting Action Group [actionGroup] actionGroupContainsStepKeyInArgValue");
 }
+
+public function _passed(AcceptanceTester $I)
+{
+// Deleting itself so that we can rerun only failed tests.
+unlink(__FILE__);
+}
 }

dev/tests/verification/Resources/ActionGroupMergedViaInsertAfter.txt

@@ -35,4 +35,10 @@ class ActionGroupMergedViaInsertAfterCest
 $I->fillField("#baz", "baz"); // stepKey: fillField3Keyone
 $I->comment("Exiting Action Group [keyone] FunctionalActionGroupForMassMergeAfter");
 }
+
+public function _passed(AcceptanceTester $I)
+{
+// Deleting itself so that we can rerun only failed tests.
+unlink(__FILE__);
+}
 }

dev/tests/verification/Resources/ActionGroupMergedViaInsertBefore.txt

@@ -35,4 +35,10 @@ class ActionGroupMergedViaInsertBeforeCest
 $I->fillField("#baz", "baz"); // stepKey: fillField3Keyone
 $I->comment("Exiting Action Group [keyone] FunctionalActionGroupForMassMergeBefore");
 }
+
+public function _passed(AcceptanceTester $I)
+{
+// Deleting itself so that we can rerun only failed tests.
+unlink(__FILE__);
+}
 }

dev/tests/verification/Resources/ActionGroupReturningValueTest.txt

@@ -72,4 +72,10 @@ class ActionGroupReturningValueTestCest
 $I->see($actionGroupWithReturnValue1, "#element .{$actionGroupWithReturnValue1}"); // stepKey: see1ActionGroupWithStringUsage1
 $I->comment("Exiting Action Group [actionGroupWithStringUsage1] actionGroupWithStringUsage");
 }
+
+public function _passed(AcceptanceTester $I)
+{
+// Deleting itself so that we can rerun only failed tests.
+unlink(__FILE__);
+}
 }

dev/tests/verification/Resources/ActionGroupToExtend.txt

@@ -31,4 +31,10 @@ class ActionGroupToExtendCest
 $I->assertCount(99, $grabProductsActionGroup); // stepKey: assertCountActionGroup
 $I->comment("Exiting Action Group [actionGroup] ActionGroupToExtend");
 }
+
+public function _passed(AcceptanceTester $I)
+{
+// Deleting itself so that we can rerun only failed tests.
+unlink(__FILE__);
+}
 }

dev/tests/verification/Resources/ActionGroupUsingCreateData.txt

@@ -39,4 +39,10 @@ class ActionGroupUsingCreateDataCest
 public function ActionGroupUsingCreateData(AcceptanceTester $I)
 {
 }
+
+public function _passed(AcceptanceTester $I)
+{
+// Deleting itself so that we can rerun only failed tests.
+unlink(__FILE__);
+}
 }

dev/tests/verification/Resources/ActionGroupUsingNestedArgument.txt

@@ -31,4 +31,10 @@ class ActionGroupUsingNestedArgumentCest
 $I->assertCount(99, $grabProductsActionGroup); // stepKey: assertCountActionGroup
 $I->comment("Exiting Action Group [actionGroup] ActionGroupToExtend");
 }
+
+public function _passed(AcceptanceTester $I)
+{
+// Deleting itself so that we can rerun only failed tests.
+unlink(__FILE__);
+}
 }

dev/tests/verification/Resources/ActionGroupWithDataOverrideTest.txt

@@ -73,4 +73,10 @@ class ActionGroupWithDataOverrideTestCest
 $I->comment("Exiting Action Group [actionGroupWithDataOverride1] FunctionalActionGroupWithData");
 $I->click("loginButton"); // stepKey: step6
 }
+
+public function _passed(AcceptanceTester $I)
+{
+// Deleting itself so that we can rerun only failed tests.
+unlink(__FILE__);
+}
 }

dev/tests/verification/Resources/ActionGroupWithDataTest.txt

@@ -73,4 +73,10 @@ class ActionGroupWithDataTestCest
 $I->comment("Exiting Action Group [actionGroupWithData1] FunctionalActionGroupWithData");
 $I->click("loginButton"); // stepKey: step6
 }
+
+public function _passed(AcceptanceTester $I)
+{
+// Deleting itself so that we can rerun only failed tests.
+unlink(__FILE__);
+}
 }