MQE-957: MFTF Changes to support DEVOPS-2029

- add new skipped logic to TestObject - update Group Object file generation to include try/catch

Author: imeron2433

src/Magento/FunctionalTestingFramework/Allure/Adapter/MagentoAllureAdapter.php

@@ -6,6 +6,7 @@
 namespace Magento\FunctionalTestingFramework\Allure\Adapter;
 
 use Magento\FunctionalTestingFramework\Data\Argument\Interpreter\NullType;
+use Magento\FunctionalTestingFramework\Suite\Handlers\SuiteObjectHandler;
 use Yandex\Allure\Adapter\AllureAdapter;
 use Codeception\Event\SuiteEvent;
 
@@ -44,7 +45,7 @@ public function suiteBefore(SuiteEvent $suiteEvent)
 
  if ($this->getGroup() != null) {
  $suite = $suiteEvent->getSuite();
- $suiteName = ($suite->getName()) . "\\" . $this->getGroup();
+ $suiteName = ($suite->getName()) . "\\" . $this->sanitizeGroupName($this->getGroup());
 
  call_user_func(\Closure::bind(
  function () use ($suite, $suiteName) {
@@ -64,4 +65,30 @@ function () use ($suite, $suiteName) {
  // call parent function
  parent::suiteBefore($changeSuiteEvent);
  }
+
+ /**
+ * Function which santizes any group names changed by the framework for execution in order to consolidate reporting.
+ *
+ * @param string $group
+ * @return string
+ */
+ private function sanitizeGroupName($group)
+ {
+ $suiteNames = array_keys(SuiteObjectHandler::getInstance()->getAllObjects());
+ $exactMatch = in_array($group, $suiteNames);
+
+ // if this is an existing suite name we dont' need to worry about changing it
+ if ($exactMatch || strpos($group, "_") === false) {
+ return $group;
+ }
+
+ // if we can't find this group in the generated suites we have to assume that the group was split for generation
+ $groupNameSplit = explode("_", $group);
+ array_pop($groupNameSplit);
+ $originalName = implode("_", $groupNameSplit);
+
+ // confirm our original name is one of the existing suite names otherwise just return the original group name
+ $originalName = in_array($originalName, $suiteNames) ? $originalName : $group;
+ return $originalName;
+ }
 }

src/Magento/FunctionalTestingFramework/Suite/views/partials/testActions.mustache

@@ -10,17 +10,21 @@ if ($webDriver->webDriver != null) {
 
 // initialize the webdriver session
 $webDriver->_initializeSession();
-
-// execute user specified actions
+try {
+ // execute user specified actions
 {{/webDriverInit}}
 {{#webDriverReset}}
+} catch (\Exception $e) {
+ print $e->getMessage();
+}
+
 // reset configuration and close session
 $this->getModule('\Magento\FunctionalTestingFramework\Module\MagentoWebDriver')->_resetConfig();
 $webDriver->webDriver->close();
 $webDriver->webDriver = null;
 {{/webDriverReset}}
 {{#action}}
-{{{action}}}
+ {{{action}}}
 {{/action}}
 {{#createData}}
 ${{entityName}} = DataObjectHandler::getInstance()->getObject("{{entityName}}");

src/Magento/FunctionalTestingFramework/Test/Objects/TestObject.php

@@ -132,6 +132,10 @@ public function getAnnotations()
  */
  public function getHooks()
  {
+ // if this test is skipped we do not want any before/after actions to generate as the tests will not run
+ if ($this->isSkipped()) {
+ return [];
+ }
  return $this->hooks;
  }
 
@@ -142,6 +146,11 @@ public function getHooks()
  */
  public function getTestActionCount()
  {
+ // a skipped action results in a single skip being appended to the beginning of the test and no execution
+ if ($this->isSkipped()) {
+ return 1;
+ }
+
  $hookActions = 0;
  if (array_key_exists('before', $this->hooks)) {
  $hookActions += count($this->hooks['before']->getActions());
@@ -152,7 +161,6 @@ public function getTestActionCount()
  }
 
  $testActions = count($this->getOrderedActions());
-
  return $hookActions + $testActions;
  }