Merge pull request magento#323 from magento-commerce/suite-hotfix

Suite hotfix

Author: okolesnyk

CHANGELOG.md

@@ -1,6 +1,11 @@
 Magento Functional Testing Framework Changelog
 ================================================
 
+4.3.4
+---------
+### Fixes
+* Resolving an issue when test is marked as failed due to Suite after section failure
+
 4.3.3
 ---------
 ### Enhancements

composer.json

@@ -2,7 +2,7 @@
  "name": "magento/magento2-functional-testing-framework",
  "description": "Magento2 Functional Testing Framework",
  "type": "library",
- "version": "4.3.3",
+ "version": "4.3.4",
  "license": "AGPL-3.0",
  "keywords": ["magento", "automation", "functional", "testing"],
  "config": {

composer.lock

@@ -196,8 +196,13 @@ class ActionsInDifferentModulesSuite extends \Codeception\GroupObject
  );
  $availableSessions = RemoteWebDriver::getAllSessions($wdHost);
  foreach ($availableSessions as $session) {
- $remoteWebDriver = RemoteWebDriver::createBySessionID($session['id'], $wdHost);
- $remoteWebDriver->quit();
+ try {
+ $remoteWebDriver = RemoteWebDriver::createBySessionID($session['id'], $wdHost);
+ $remoteWebDriver->quit();
+ } catch (\Exception $exception) {
+ print("Failed trying to quit WebDriver session. Exception message: " . $exception->getMessage() . " Test execution will continue." . PHP_EOL);
+ // Session already closed so nothing to do
+ }
  }
  }
  }

dev/tests/verification/Resources/ActionsInDifferentModulesSuite.txt

@@ -179,8 +179,13 @@ class functionalSuiteHooks extends \Codeception\GroupObject
  );
  $availableSessions = RemoteWebDriver::getAllSessions($wdHost);
  foreach ($availableSessions as $session) {
- $remoteWebDriver = RemoteWebDriver::createBySessionID($session['id'], $wdHost);
- $remoteWebDriver->quit();
+ try {
+ $remoteWebDriver = RemoteWebDriver::createBySessionID($session['id'], $wdHost);
+ $remoteWebDriver->quit();
+ } catch (\Exception $exception) {
+ print("Failed trying to quit WebDriver session. Exception message: " . $exception->getMessage() . " Test execution will continue." . PHP_EOL);
+ // Session already closed so nothing to do
+ }
  }
  }
  }

dev/tests/verification/Resources/functionalSuiteHooks.txt

@@ -159,8 +159,13 @@ class functionalSuiteWithComments extends \Codeception\GroupObject
  );
  $availableSessions = RemoteWebDriver::getAllSessions($wdHost);
  foreach ($availableSessions as $session) {
- $remoteWebDriver = RemoteWebDriver::createBySessionID($session['id'], $wdHost);
- $remoteWebDriver->quit();
+ try {
+ $remoteWebDriver = RemoteWebDriver::createBySessionID($session['id'], $wdHost);
+ $remoteWebDriver->quit();
+ } catch (\Exception $exception) {
+ print("Failed trying to quit WebDriver session. Exception message: " . $exception->getMessage() . " Test execution will continue." . PHP_EOL);
+ // Session already closed so nothing to do
+ }
  }
  }
  }

dev/tests/verification/Resources/functionalSuiteWithComments.txt

@@ -152,8 +152,13 @@ class {{suiteName}} extends \Codeception\GroupObject
  );
  $availableSessions = RemoteWebDriver::getAllSessions($wdHost);
  foreach ($availableSessions as $session) {
- $remoteWebDriver = RemoteWebDriver::createBySessionID($session['id'], $wdHost);
- $remoteWebDriver->quit();
+ try {
+ $remoteWebDriver = RemoteWebDriver::createBySessionID($session['id'], $wdHost);
+ $remoteWebDriver->quit();
+ } catch (\Exception $exception) {
+ print("Failed trying to quit WebDriver session. Exception message: " . $exception->getMessage() . " Test execution will continue." . PHP_EOL);
+ // Session already closed so nothing to do
+ }
  }
  }
  }