Skip to content

Commit 596fd82

Browse files
authored
Fixed tag not set correctly on certain commands (#79)
1 parent 23eb197 commit 596fd82

File tree

4 files changed

+27
-1
lines changed

4 files changed

+27
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# 3.0.2
2+
- fix absence of tag raising an error in certain cases
3+
14
# 3.0.1
25
- `bootstrap` does not require a `--tag` option
36
- `run` does not need require a `--instance`

lib/broadside/target.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ def initialize(name, options = {})
5555
@predeploy_commands = config.delete(:predeploy_commands)
5656
@scale = config.delete(:scale)
5757
@service_config = config.delete(:service_config)
58+
@tag = config.delete(:tag)
5859
@task_definition_config = config.delete(:task_definition_config)
5960

6061
@env_files = Array.wrap(config.delete(:env_files) || config.delete(:env_file)).map do |env_path|

lib/broadside/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module Broadside
2-
VERSION = '3.0.1'.freeze
2+
VERSION = '3.0.2'.freeze
33
end

spec/broadside/target_spec.rb

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,28 @@
33
describe Broadside::Target do
44
include_context 'deploy configuration'
55

6+
describe '#initialize' do
7+
let(:all_possible_options) do
8+
{
9+
bootstrap_commands: [],
10+
cluster: 'some-cluster',
11+
command: %w(some command),
12+
docker_image: 'lumoslabs/hello',
13+
env_file: '.env.test',
14+
predeploy_commands: [],
15+
scale: 9000,
16+
service_config: {},
17+
tag: 'latest',
18+
task_definition_config: {}
19+
}
20+
end
21+
let(:target) { described_class.new(test_target_name, all_possible_options) }
22+
23+
it 'should initialize without erroring using all possible options' do
24+
expect { target }.to_not raise_error
25+
end
26+
end
27+
628
shared_examples 'valid_configuration?' do |succeeds, config_hash|
729
let(:valid_options) { { scale: 100 } }
830
let(:target) { described_class.new(test_target_name, valid_options.merge(config_hash)) }

0 commit comments

Comments
 (0)