Skip to content

Commit 6af8c02

Browse files
committed
Fix MoviesRepositoryTest.kt
1 parent 8bf118f commit 6af8c02

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

app/src/test/kotlin/com/fernandocejas/sample/features/movies/GetMovieDetailsTest.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ import org.junit.Test
2626

2727
class GetMovieDetailsTest : UnitTest() {
2828

29-
private val MOVIE_ID = 1
30-
3129
private lateinit var getMovieDetails: GetMovieDetails
3230

3331
@MockK private lateinit var moviesRepository: MoviesRepository
@@ -42,4 +40,8 @@ class GetMovieDetailsTest : UnitTest() {
4240

4341
verify(exactly = 1) { moviesRepository.movieDetails(MOVIE_ID) }
4442
}
43+
44+
companion object {
45+
private const val MOVIE_ID = 1
46+
}
4547
}

app/src/test/kotlin/com/fernandocejas/sample/features/movies/MoviesRepositoryTest.kt

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,9 @@ class MoviesRepositoryTest : UnitTest() {
100100

101101
@Test fun `movies service should return server error if no successful response`() {
102102
every { networkHandler.isConnected } returns true
103+
every { moviesResponse.isSuccessful } returns false
104+
every { moviesCall.execute() } returns moviesResponse
105+
every { service.movies() } returns moviesCall
103106

104107
val movies = networkRepository.movies()
105108

@@ -110,6 +113,8 @@ class MoviesRepositoryTest : UnitTest() {
110113

111114
@Test fun `movies request should catch exceptions`() {
112115
every { networkHandler.isConnected } returns true
116+
every { moviesCall.execute() } returns moviesResponse
117+
every { service.movies() } returns moviesCall
113118

114119
val movies = networkRepository.movies()
115120

@@ -171,6 +176,10 @@ class MoviesRepositoryTest : UnitTest() {
171176

172177
@Test fun `movie details service should return server error if no successful response`() {
173178
every { networkHandler.isConnected } returns true
179+
every { movieDetailsResponse.body() } returns null
180+
every { movieDetailsResponse.isSuccessful } returns false
181+
every { movieDetailsCall.execute() } returns movieDetailsResponse
182+
every { service.movieDetails(1) } returns movieDetailsCall
174183

175184
val movieDetails = networkRepository.movieDetails(1)
176185

@@ -181,6 +190,8 @@ class MoviesRepositoryTest : UnitTest() {
181190

182191
@Test fun `movie details request should catch exceptions`() {
183192
every { networkHandler.isConnected } returns true
193+
every { movieDetailsCall.execute() } returns movieDetailsResponse
194+
every { service.movieDetails(1) } returns movieDetailsCall
184195

185196
val movieDetails = networkRepository.movieDetails(1)
186197

0 commit comments

Comments
 (0)