Add and setup static analysis: Detekt.

Author: android10

README.md

@@ -55,6 +55,7 @@ Here are some useful Gradle/adb commands for executing this example:
  * `./gradlew runUnitTests` - Execute unit tests (both unit and integration).
  * `./gradlew runAcceptanceTests` - Execute acceptance and instrumentation tests in the connected device.
  * `./gradlew runTestCoverage` - Reports code coverage on tests within the Android codebase.
+ * `./gradlew runStaticCodeAnalysis` - Run static analysis on the Android codebase.
 
 ## Discussions
 Refer to the issues section: https://github.com/android10/Android-CleanArchitecture-Kotlin/issues

app/src/test/kotlin/com/fernandocejas/sample/features/movies/MoviesRepositoryTest.kt

@@ -122,7 +122,7 @@ class MoviesRepositoryTest : UnitTest() {
  val movieDetails = networkRepository.movieDetails(1)
 
  movieDetails shouldEqual Right(MovieDetails.empty())
- verify(exactly = 1) {service.movieDetails(1) }
+ verify(exactly = 1) { service.movieDetails(1) }
  }
 
  @Test fun `should get movie details from service`() {

buildSrc/build.gradle.kts

@@ -1,5 +1,6 @@
 object Dependencies {
  const val AndroidBuildTools = "com.android.tools.build:gradle:4.0.1"
+ const val detektGradlePlugin = "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.14.1"
 }
 
 plugins {
@@ -14,4 +15,5 @@ repositories {
 
 dependencies {
  implementation(Dependencies.AndroidBuildTools)
+ implementation(Dependencies.detektGradlePlugin)
 }

buildSrc/src/main/kotlin/scripts/quality.gradle.kts

@@ -1,10 +1,12 @@
 package scripts
 
+import io.gitlab.arturbosch.detekt.Detekt
 import scripts.Variants_gradle.*
 
 plugins {
  id("com.android.application") apply false
  id("jacoco")
+ id("io.gitlab.arturbosch.detekt")
 }
 
 android {
@@ -71,4 +73,29 @@ tasks.register("runTestCoverage") {
  group = "Quality"
  description = "Report code coverage on tests within the Android codebase."
  dependsOn("jacocoReport")
-}
+}
+
+val detektAll by tasks.registering(Detekt::class) {
+ group = "Quality"
+ description = "Runs a detekt code analysis ruleset on the Android codebase."
+ parallel = true
+ buildUponDefaultConfig = true
+
+ setSource(files(rootProject.projectDir))
+ config.setFrom(project.rootDir.resolve("config/detekt/detekt.yml"))
+
+ include("**/*.kt")
+ exclude("**/*.kts", "*/build/*", "/buildSrc")
+
+ reports {
+ xml.enabled = true
+ html.enabled = true
+ txt.enabled = false
+ }
+}
+
+tasks.register("runStaticCodeAnalysis") {
+ description = "Run static analysis on the Android codebase."
+ dependsOn(detektAll)
+}
+