Improve tests

Author: timacdonald

tests/Integration/Database/DatabaseConnectionsTest.php

@@ -178,7 +178,7 @@ public function testDynamicConnectionWithNoNameDoesntFailOnReconnect()
  }
 
  #[DataProvider('readWriteExpectations')]
- public function testItCanAccessLastReadWriteConnectionTypeRetrieved(string $connectionName, array $expectedTypes, ?string $loggedType)
+ public function testReadWriteTypeIsProvidedInQueryExecutedEventAndQueryLog(string $connectionName, array $expectedTypes, ?string $loggedType)
  {
  $readPath = __DIR__.'/read.sqlite';
  $writePath = __DIR__.'/write.sqlite';
@@ -213,6 +213,7 @@ public function testItCanAccessLastReadWriteConnectionTypeRetrieved(string $conn
  $connection->select('select 1');
  $this->assertSame(array_shift($expectedTypes), $events->shift()->readWriteType);
 
+ $this->assertEmpty($events);
  $this->assertSame([
  ['query' => 'select 1', 'readWriteType' => $loggedType ?? 'write'],
  ['query' => 'select 1', 'readWriteType' => $loggedType ?? 'read'],
@@ -234,7 +235,7 @@ public static function readWriteExpectations(): iterable
  yield 'sqlite::write' => ['sqlite::write', ['write', 'write', 'write', 'write'], 'write'];
  }
 
- public function testNonReadWriteConnectionsAlwaysUseWrite()
+ public function testConnectionsWithoutReadWriteConfigurationAlwaysShowAsWrite()
  {
  $writePath = __DIR__.'/write.sqlite';
  Config::set('database.connections.sqlite', [
@@ -265,7 +266,7 @@ public function testNonReadWriteConnectionsAlwaysUseWrite()
  }
  }
 
- public function testQueryExceptionsCaptureReadWriteType()
+ public function testQueryExceptionsProviderReadWriteType()
  {
  $readPath = __DIR__.'/read.sqlite';
  $writePath = __DIR__.'/write.sqlite';