Cleanup: Scrutinizer fixes.

Author: adri

src/VCR/LibraryHooks/CurlHook.php

@@ -176,7 +176,7 @@ public static function curlInit($url = null)
  * Perform a cURL session.
  *
  * @link http://www.php.net/manual/en/function.curl-exec.php
- * @param string $curlHandle A cURL handle returned by curl_init().
+ * @param resource $curlHandle A cURL handle returned by curl_init().
  *
  * @return mixed Returns TRUE on success or FALSE on failure.
  * However, if the CURLOPT_RETURNTRANSFER option is set, it will return the
@@ -307,7 +307,7 @@ public static function curlSetopt($curlHandle, $option, $value)
 
  static::$curlOptions[(int) $curlHandle][$option] = $value;
 
- \curl_setopt($curlHandle, $option, $value);
+ return \curl_setopt($curlHandle, $option, $value);
  }
 
  /**

src/VCR/Storage/Json.php

@@ -83,7 +83,7 @@ public function current()
  /**
  * Returns the current key.
  *
- * @return void
+ * @return integer
  */
  public function key()
  {
@@ -125,7 +125,6 @@ protected function readNextRecord()
  }
 
  if ($isInRecord && $char === '}' && $depth == 0) {
- $isInRecord = false;
  break;
  }
  }

src/VCR/Storage/Yaml.php

@@ -92,7 +92,7 @@ public function current()
  /**
  * Returns the current key.
  *
- * @return void
+ * @return integer
  */
  public function key()
  {
@@ -131,7 +131,6 @@ private function readNextRecord()
  $lastChar = $char;
 
  if ($isInRecord && $isNewArrayStart) {
- $isInRecord = false;
  fseek($this->handle, -1, SEEK_CUR);
  break;
  }

src/VCR/Util/StreamProcessor.php

@@ -362,6 +362,8 @@ public function unlink($path)
  public function stream_metadata($path, $option, $value)
  {
  $this->restore();
+ $result = null;
+
  switch ($option) {
  case STREAM_META_TOUCH:
  if (empty($value)) {