Skip to content

Commit 3d68181

Browse files
author
Jose Ramirez
committed
Fixed unit tests failing due to missing permissions on the mysql.user table.
1 parent 5ad9129 commit 3d68181

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

Tests/MySql.Data.Tests/MySqlCommandTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public void InvalidCast()
5454
string password = "123";
5555
if (!st.conn.driver.Version.isAtLeast(5,7,0))
5656
{
57-
st.ExecuteSQLAsRoot(string.Format("GRANT USAGE ON *.* TO '{0}'@'localhost'", st.conn.Settings.UserID));
57+
st.ExecuteSQLAsRoot(string.Format("GRANT SELECT ON mysql.user TO '{0}'@'localhost'", st.conn.Settings.UserID));
5858
var command = st.conn.CreateCommand();
5959
command.CommandText = string.Format("SELECT count(*) FROM mysql.user WHERE user LIKE '{0}%'", userName);
6060
if ((long) command.ExecuteScalar() > 0)

Tests/MySql.Data.Tests/MySqlConnectionTests.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@ public void SetFixture(SetUpClass data)
4646
st = data;
4747
}
4848

49-
[Fact]
50-
public void test()
51-
{ }
52-
5349
[Fact]
5450
public void TestConnectionStrings()
5551
{
@@ -1412,6 +1408,7 @@ public void ConnectUsingMySqlNativePasswordPlugin()
14121408
Assert.Contains("TLSv1", reader.GetString(1));
14131409
}
14141410

1411+
st.ExecuteSQLAsRoot(string.Format("GRANT SELECT ON mysql.user TO '{0}'@'localhost'", userName));
14151412
command.CommandText = String.Format("SELECT `User`, `plugin` FROM `mysql`.`user` WHERE `User` = '{0}';", userName);
14161413
using (MySqlDataReader reader = command.ExecuteReader())
14171414
{

Tests/MySql.Data.Tests/SetUp.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ internal protected string CreateUser(string userName, string password, string pl
436436
}
437437
else
438438
{
439-
ExecuteSQLAsRoot(string.Format("GRANT USAGE ON *.* TO '{0}'@'localhost'", connection.Settings.UserID));
439+
ExecuteSQLAsRoot(string.Format("GRANT SELECT ON mysql.user TO '{0}'@'localhost'", connection.Settings.UserID));
440440
var cmd = connection.CreateCommand();
441441
cmd.CommandText = string.Format("SELECT count(*) FROM mysql.user WHERE user LIKE '{0}%'", userName);
442442
if ((long)cmd.ExecuteScalar() > 0)

0 commit comments

Comments
 (0)