-
- Notifications
You must be signed in to change notification settings - Fork 159
OpenAPI: Generalization of naming conventions #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
d1071ea to aa90296 Compare 92bb994 to 2190d0e Compare 72fa478 to 429883f Compare …et in SerializerSettings for properties in swagger doc
ec85fd5 to f6c01f2 Compare bart-degreed suggested changes Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with review pass.
src/JsonApiDotNetCore.OpenApi/SwaggerComponents/NullableReferenceSchemaGenerator.cs Outdated Show resolved Hide resolved
test/OpenApiTests/NamingConvention/KebabCase/KebabCaseNamingConventionStartup.cs Outdated Show resolved Hide resolved
This comment has been minimized.
This comment has been minimized.
bcc22be to c3f6708 Compare c3f6708 to b43807a Compare fab3a78 to 45dd549 Compare bart-degreed suggested changes Dec 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look at other parts later
…g.json in client test project
650edad to f51eb63 Compare f51eb63 to e835b33 Compare bart-degreed suggested changes Dec 20, 2021
test/OpenApiTests/NamingConventions/CamelCase/CamelCaseTests.cs Outdated Show resolved Hide resolved
test/OpenApiTests/NamingConventions/KebabCase/KebabCaseTests.cs Outdated Show resolved Hide resolved
6ed2db0 to c7eff0a Compare bart-degreed approved these changes Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #1080