Skip to content

Conversation

@maurei
Copy link
Member

@maurei maurei commented Dec 6, 2021

Closes #1080

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #1123 (9f3f665) into openapi (fa28605) will increase coverage by 0.00%.
The diff coverage is 98.16%.

Impacted file tree graph

@@ Coverage Diff @@ ## openapi #1123 +/- ## ======================================== Coverage 89.43% 89.43% ======================================== Files 301 303 +2 Lines 8263 8283 +20 ======================================== + Hits 7390 7408 +18  - Misses 873 875 +2 
Impacted Files Coverage Δ
...ents/NullableResourceIdentifierResponseDocument.cs 0.00% <ø> (ø)
...ments/NullableSecondaryResourceResponseDocument.cs 0.00% <ø> (ø)
...jects/Documents/PrimaryResourceResponseDocument.cs 0.00% <ø> (ø)
...ts/Documents/ResourceCollectionResponseDocument.cs 0.00% <ø> (ø)
...ts/ResourceIdentifierCollectionResponseDocument.cs 0.00% <ø> (ø)
...ts/Documents/ResourceIdentifierResponseDocument.cs 0.00% <ø> (ø)
...cts/Documents/SecondaryResourceResponseDocument.cs 0.00% <ø> (ø)
...DotNetCore.OpenApi/JsonApiObjects/JsonapiObject.cs 0.00% <ø> (ø)
.../JsonApiObjects/Links/LinksInRelationshipObject.cs 0.00% <ø> (ø)
...Objects/Links/LinksInResourceCollectionDocument.cs 0.00% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa28605...9f3f665. Read the comment docs.

@maurei maurei force-pushed the openapi-naming-convention branch 5 times, most recently from 92bb994 to 2190d0e Compare December 13, 2021 12:49
@maurei maurei marked this pull request as ready for review December 13, 2021 13:54
@maurei maurei force-pushed the openapi-naming-convention branch 6 times, most recently from 72fa478 to 429883f Compare December 14, 2021 18:39
…et in SerializerSettings for properties in swagger doc
- Fixed hanging CI by adding xunit.runner.json - Moved retrieval of swagger document to test context fixture
@maurei maurei force-pushed the openapi-naming-convention branch from ec85fd5 to f6c01f2 Compare December 15, 2021 10:44
Copy link
Contributor

@bart-degreed bart-degreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass.

@bart-degreed

This comment has been minimized.

@maurei maurei force-pushed the openapi-naming-convention branch 3 times, most recently from bcc22be to c3f6708 Compare December 15, 2021 17:42
@maurei maurei force-pushed the openapi-naming-convention branch from c3f6708 to b43807a Compare December 16, 2021 10:24
@maurei maurei force-pushed the openapi-naming-convention branch from fab3a78 to 45dd549 Compare December 16, 2021 12:21
Copy link
Contributor

@bart-degreed bart-degreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look at other parts later

@maurei maurei force-pushed the openapi-naming-convention branch 2 times, most recently from 650edad to f51eb63 Compare December 20, 2021 11:56
@maurei maurei force-pushed the openapi-naming-convention branch from f51eb63 to e835b33 Compare December 20, 2021 12:12
@maurei maurei force-pushed the openapi-naming-convention branch from 6ed2db0 to c7eff0a Compare December 20, 2021 15:22
@bart-degreed bart-degreed merged commit 3e01136 into openapi Dec 21, 2021
@bart-degreed bart-degreed deleted the openapi-naming-convention branch December 21, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants