fix unwrap on typed nil #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
isopov commented Jul 3, 2023
| // %s simple message output | ||
| // %v same as %s | ||
| // %+v full output complete with a stack trace | ||
| // %s simple message output |
Contributor Author
There was a problem hiding this comment.
Latest go reformats comments this way - can I leave it this way? Other contributors most likely will use modern go as well.
PeterIvanov approved these changes Jul 4, 2023
Collaborator
PeterIvanov left a comment
PeterIvanov left a comment There was a problem hiding this comment.
In any particular codebase, I'd rather fix the bad calls to Unwrap or find where the typed nil is returned as a result (alas, I failed to find the relevant reference, it must be in Effective Go or similar article).
But for a library, this seems like a good patch.
Collaborator
| @isopov friendly colleague pointed to this: https://go.dev/doc/faq#nil_error |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It seems that I have some typed as
*errorx.Errornil and cannot debug its source - maybe we can ignore it instead of throwing NPD and it will manifest in a more readable way somewhere else?