remove some duplicates

Author: zhidelev

.github/workflows/jdi-python.yml

@@ -31,9 +31,10 @@ jobs:
  - name: Download Chrome driver
  run: |
  python get_driver.py
- - name: Run tests
- run: |
- python -m unittest Test\jdi_uitests_webtests\test\run_all_tests.py -v
+ # TODO: use virtual machine for tests run
+ # - name: Run tests
+ # run: |
+ # python -m unittest Test\jdi_uitests_webtests\test\run_all_tests.py -v
  shell: cmd
  - name: Save debug log file
  uses: actions/upload-artifact@v2

JDI/web/selenium/settings/WebSettings.py

@@ -19,7 +19,7 @@ def set_driver_factory(driver_factory):
 
  @staticmethod
  def use_driver(options=None, capabilities=None, executor=None):
- driver_name = JDISettings.get_setting_by_name('driver')
+ driver_name = JDISettings.get_setting_by_name("driver")
  JDISettings._driver_factory = SeleniumDriverFactory()
  WebSettings.set_driver_factory(JDISettings._driver_factory)
  return JDISettings._driver_factory.register_driver(driver_name, options, capabilities, executor)
@@ -35,4 +35,4 @@ def quit_browser():
 
  @staticmethod
  def get_driver():
- return WebSettings.get_driver_factory().get_driver()
+ return WebSettings.get_driver_factory().get_driver()

JDI/web/selenium/settings/web_settings.py

@@ -1,61 +1,53 @@
 from enum import Enum
-
+from abc import ABCMeta, abstractmethod
 from JDI.web.selenium.elements.api_interact.find_element_by import By
 from JDI.web.selenium.elements.complex.radio_buttons import RadioButtons
 from JDI.web.selenium.elements.complex.selector import Selector
 from JDI.web.selenium.elements.composite.section import Section
 
+ERROR_MSG = "No elements selected. Override getSelectedAction or place locator to <select> tag"
 
-class RadioButtonsSummary(RadioButtons):
- def get_selected(self):
- el = list(filter(lambda x: x.is_selected(), self.get_input_web_elements()))
- if len(el) == 0:
- raise Exception("No elements selected. Override getSelectedAction or place locator to <select> tag")
- return el[0].find_element_by_xpath("..").text
 
+class SelectElements(metaclass=ABCMeta):
+ @abstractmethod
  def get_input_web_elements(self):
- return list(map(lambda el: el.find_element_by_tag_name("input"),
- super(RadioButtonsSummary, self).get_web_elements()))
+ raise NotImplementedError
 
- def is_selected_action(self, el):
- actual_text = list(filter(lambda x: x.is_selected(), self.get_input_web_elements()))[0].find_element_by_xpath(
- "..").text
- if isinstance(el, str):
- return actual_text == el
- if isinstance(el, Enum):
- return actual_text == el.value
+ def get_selected(self):
+ element = list(filter(lambda x: x.is_selected(), self.get_input_web_elements()))
+ if len(element) == 0:
+ raise ValueError(ERROR_MSG)
+ return element[0].find_element_by_xpath("..").text
+
+ def is_selected_action(self, element) -> bool:
+ actual_text = (
+ list(filter(lambda x: x.is_selected(), self.get_input_web_elements()))[0].find_element_by_xpath("..").text
+ )
+ if isinstance(element, str):
+ return actual_text == element
+ elif isinstance(element, Enum):
+ return actual_text == element.value
+ return False
 
  def get_selected_index(self):
  try:
  return list(map(lambda x: x.is_selected(), self.get_input_web_elements())).index(True)
  except ValueError:
- raise ValueError("No elements selected. Override getSelectedAction or place locator to <select> tag")
+ raise ValueError(ERROR_MSG) from None
 
 
-class SelectorSummary(Selector):
- def get_selected(self):
- el = list(filter(lambda x: x.is_selected(), self.get_input_web_elements()))
- if len(el) == 0:
- raise Exception("No elements selected. Override getSelectedAction or place locator to <select> tag")
- return el[0].find_element_by_xpath("..").text
-
+class RadioButtonsSummary(SelectElements, RadioButtons):
  def get_input_web_elements(self):
- return list(map(lambda el: el.find_element_by_tag_name("input"),
- super(SelectorSummary, self).get_web_elements()))
+ return list(
+ map(lambda el: el.find_element_by_tag_name("input"), super(RadioButtonsSummary, self).get_web_elements())
+ )
 
- def is_selected_action(self, el):
- actual_text = list(filter(lambda x: x.is_selected(), self.get_input_web_elements()))[0].find_element_by_xpath(
- "..").text
- if isinstance(el, str):
- return actual_text == el
- if isinstance(el, Enum):
- return actual_text == el.value
 
- def get_selected_index(self):
-  try:
-  return list(map(lambda x: x.is_selected(), self.get_input_web_elements())).index(True)
- except ValueError:
-  raise ValueError("No elements selected. Override getSelectedAction or place locator to <select> tag")
+class SelectorSummary(SelectElements, Selector):
+ def get_input_web_elements(self):
+ return list(
+  map(lambda el: el.find_element_by_tag_name("input"), super(SelectorSummary, self).get_web_elements())
+ )
 
 
 class Summary(Section):

Test/jdi_uitests_webtests/main/page_objects/sections/summary.py

@@ -5,29 +5,31 @@
 from Test.jdi_uitests_webtests.main.utils.common_action_data import CommonActionsData
 from Test.jdi_uitests_webtests.test.init_tests import InitTests
 
+MSG = "Colors: value changed to Blue"
+
 
 class DropdownExpandedTests(InitTests):
 
  odd_options = ["Colors", "Red", "Green", "Blue", "Yellow"]
 
  dropdown = EpamJDISite.metals_colors_page.color_dropdown
 
- def setUp(self):
+ def setUp(self, name="DropdownExpandedTests"):
  super(DropdownExpandedTests, self).setUp(self.id().split(".")[-1])
  Preconditions.METALS_AND_COLORS_PAGE.is_in_state()
  self.dropdown.expand()
 
  def test_select_string(self):
  self.dropdown.select("Blue")
- CommonActionsData.check_action("Colors: value changed to Blue")
+ CommonActionsData.check_action(MSG)
 
  def test_select_index(self):
  self.dropdown.select(4)
- CommonActionsData.check_action("Colors: value changed to Blue")
+ CommonActionsData.check_action(MSG)
 
  def test_select_enum(self):
  self.dropdown.select(Colors.BLUE)
- CommonActionsData.check_action("Colors: value changed to Blue")
+ CommonActionsData.check_action(MSG)
 
  def test_get_options(self):
  Assert.assert_equal(self.dropdown.get_options(), self.odd_options)
@@ -43,7 +45,7 @@ def test_get_options_as_text(self):
 
  def test_set_value(self):
  self.dropdown.set_value("Blue")
- CommonActionsData.check_action("Colors: value changed to Blue")
+ CommonActionsData.check_action(MSG)
 
  def test_get_name(self):
  Assert.assert_equal(self.dropdown.get_name(), "color_dropdown")
@@ -52,7 +54,9 @@ def test_get_selected(self):
  Assert.assert_equal(self.dropdown.get_selected(), "Colors")
 
  def test_get_selected_index(self):
- CommonActionsData.check_action_throw_error(lambda: self.dropdown.get_selected_index(), CommonActionsData.no_elements_message())
+ CommonActionsData.check_action_throw_error(
+ lambda: self.dropdown.get_selected_index(), CommonActionsData.no_elements_message()
+ )
 
  def test_is_selected(self):
  Assert.assert_equal(self.dropdown.is_selected("Colors"), True)
@@ -61,4 +65,4 @@ def test_is_selected_enum(self):
  Assert.assert_equal(self.dropdown.is_selected(Colors.COLORS), True)
 
  def test_get_value(self):
- Assert.assert_equal(self.dropdown.get_value(), "Colors")
+ Assert.assert_equal(self.dropdown.get_value(), "Colors")

Test/jdi_uitests_webtests/test/complex/dropdown_expanded_tests.py

@@ -5,28 +5,30 @@
 from Test.jdi_uitests_webtests.main.utils.common_action_data import CommonActionsData
 from Test.jdi_uitests_webtests.test.init_tests import InitTests
 
+MSG = "Colors: value changed to Blue"
+
 
 class DropdownTests(InitTests):
 
  odd_options = ["Colors", "Red", "Green", "Blue", "Yellow"]
 
  dropdown = EpamJDISite.metals_colors_page.color_dropdown
 
- def setUp(self):
+ def setUp(self, name="DropdownTests"):
  super(DropdownTests, self).setUp(self.id().split(".")[-1])
  Preconditions.METALS_AND_COLORS_PAGE.is_in_state()
 
  def test_select_string(self):
  self.dropdown.select("Blue")
- CommonActionsData.check_action("Colors: value changed to Blue")
+ CommonActionsData.check_action(MSG)
 
  def test_select_index(self):
  self.dropdown.select(4)
- CommonActionsData.check_action("Colors: value changed to Blue")
+ CommonActionsData.check_action(MSG)
 
  def test_select_enum(self):
  self.dropdown.select(Colors.BLUE)
- CommonActionsData.check_action("Colors: value changed to Blue")
+ CommonActionsData.check_action(MSG)
 
  def test_get_options(self):
  Assert.assert_equal(self.dropdown.get_options(), self.odd_options)
@@ -42,7 +44,7 @@ def test_get_options_as_text(self):
 
  def test_set_value(self):
  self.dropdown.set_value("Blue")
- CommonActionsData.check_action("Colors: value changed to Blue")
+ CommonActionsData.check_action(MSG)
 
  def test_get_name(self):
  Assert.assert_equal(self.dropdown.get_name(), "color_dropdown")
@@ -51,13 +53,15 @@ def test_get_selected(self):
  Assert.assert_equal(self.dropdown.get_selected(), "Colors")
 
  def test_get_selected_index(self):
- CommonActionsData.check_action_throw_error(lambda: self.dropdown.get_selected_index(), CommonActionsData.no_elements_message())
- 
+ CommonActionsData.check_action_throw_error(
+ lambda: self.dropdown.get_selected_index(), CommonActionsData.no_elements_message()
+ )
+
  def test_is_selected(self):
  Assert.assert_equal(self.dropdown.is_selected("Colors"), True)
 
  def test_is_selected_enum(self):
  Assert.assert_equal(self.dropdown.is_selected(Colors.COLORS), True)
 
  def test_get_value(self):
- Assert.assert_equal(self.dropdown.get_value(), "Colors")
+ Assert.assert_equal(self.dropdown.get_value(), "Colors")

Test/jdi_uitests_webtests/test/complex/dropdown_tests.py

@@ -5,6 +5,8 @@
 from Test.jdi_uitests_webtests.main.utils.common_action_data import CommonActionsData
 from Test.jdi_uitests_webtests.test.init_tests import InitTests
 
+MSG = "Summary (Odd): value changed to 7"
+
 
 class RadioButtonTests(InitTests):
  odd_options = ["1", "3", "5", "7"]
@@ -17,15 +19,15 @@ def setUp(self):
 
  def test_select_string(self):
  self.radio_buttons.select("7")
- CommonActionsData.check_action("Summary (Odd): value changed to 7")
+ CommonActionsData.check_action(MSG)
 
  def test_select_index(self):
  self.radio_buttons.select(4)
- CommonActionsData.check_action("Summary (Odd): value changed to 7")
+ CommonActionsData.check_action(MSG)
 
  def test_select_enum(self):
  self.radio_buttons.select(Odds.SEVEN)
- CommonActionsData.check_action("Summary (Odd): value changed to 7")
+ CommonActionsData.check_action(MSG)
 
  def test_get_options(self):
  Assert.assert_equal(self.radio_buttons.get_options(), self.odd_options)
@@ -41,10 +43,10 @@ def test_get_options_as_text(self):
 
  def test_set_value_text(self):
  self.radio_buttons.set_value("7")
- CommonActionsData.check_action("Summary (Odd): value changed to 7")
+ CommonActionsData.check_action(MSG)
 
  def test_get_name(self):
- Assert.assert_equal(self.radio_buttons.get_name(),"odds_radio_buttons")
+ Assert.assert_equal(self.radio_buttons.get_name(), "odds_radio_buttons")
 
  def test_get_selected(self):
  Assert.assert_equal(self.radio_buttons.get_selected(), "1")

Test/jdi_uitests_webtests/test/complex/radio_button_tests.py

@@ -5,6 +5,8 @@
 from Test.jdi_uitests_webtests.main.utils.common_action_data import CommonActionsData
 from Test.jdi_uitests_webtests.test.init_tests import InitTests
 
+MSG = "Summary (Odd): value changed to 7"
+
 
 class SelectorTests(InitTests):
  odd_options = ["1", "3", "5", "7"]
@@ -17,15 +19,15 @@ def setUp(self):
 
  def test_select_string(self):
  self.radio_buttons.select("7")
- CommonActionsData.check_action("Summary (Odd): value changed to 7")
+ CommonActionsData.check_action(MSG)
 
  def test_select_index(self):
  self.radio_buttons.select(4)
- CommonActionsData.check_action("Summary (Odd): value changed to 7")
+ CommonActionsData.check_action(MSG)
 
  def test_select_enum(self):
  self.radio_buttons.select(Odds.SEVEN)
- CommonActionsData.check_action("Summary (Odd): value changed to 7")
+ CommonActionsData.check_action(MSG)
 
  def test_get_options(self):
  Assert.assert_equal(self.radio_buttons.get_options(), self.odd_options)
@@ -41,10 +43,10 @@ def test_get_options_as_text(self):
 
  def test_set_value_text(self):
  self.radio_buttons.set_value("7")
- CommonActionsData.check_action("Summary (Odd): value changed to 7")
+ CommonActionsData.check_action(MSG)
 
  def test_get_name(self):
- Assert.assert_equal(self.radio_buttons.get_name(),"odds_selector")
+ Assert.assert_equal(self.radio_buttons.get_name(), "odds_selector")
 
  def test_get_selected(self):
  Assert.assert_equal(self.radio_buttons.get_selected(), "1")
@@ -61,4 +63,4 @@ def test_is_selected_enum(self):
  Assert.assert_equal(self.radio_buttons.is_selected(Odds.ONE), True)
 
  def test_get_value(self):
- Assert.assert_equal(self.radio_buttons.get_value(), "1")
+ Assert.assert_equal(self.radio_buttons.get_value(), "1")