Added validation to (min/max)_(update/key)

Author: erezsh

data_diff/diff_tables.py

@@ -65,6 +65,12 @@ def __post_init__(self):
  if not self.update_column and (self.min_update or self.max_update):
  raise ValueError("Error: min_update/max_update feature requires to specify 'update_column'")
 
+ if self.min_key is not None and self.max_key is not None and self.min_key >= self.max_key:
+ raise ValueError("Error: min_key expected to be smaller than max_key!")
+
+ if self.min_update is not None and self.max_update is not None and self.min_update >= self.max_update:
+ raise ValueError("Error: min_update expected to be smaller than max_update!")
+
  def _make_key_range(self):
  if self.min_key is not None:
  yield Compare("<=", str(self.min_key), self.key_column)

tests/test_diff_tables.py

@@ -210,3 +210,16 @@ def test_diff_sorted_by_key(self):
  ("-", (4, datetime.datetime(2022, 1, 1, 0, 0))),
  ]
  self.assertEqual(expected, diff)
+
+class TestTableSegment(TestWithConnection):
+ def setUp(self) -> None:
+ self.table = TableSegment(self.connection, ("ratings_test",), "id", "timestamp")
+ self.table2 = TableSegment(self.connection, ("ratings_test2",), "id", "timestamp")
+ return super().setUp()
+
+ def test_table_segment(self):
+ early = datetime.datetime(2021, 1, 1, 0, 0)
+ late = datetime.datetime(2022, 1, 1, 0, 0)
+ self.assertRaises(ValueError, self.table.replace, min_update=late, max_update=early)
+
+ self.assertRaises(ValueError, self.table.replace, min_key=10, max_key=0)