Level 1

Author: JeroenVanOort

src/VCR/VCR.php

@@ -12,6 +12,7 @@
  * @method static void turnOn()
  * @method static void turnOff()
  * @method static void eject()
+ * @mixin Videorecorder
  */
 class VCR
 {
@@ -37,7 +38,7 @@ class VCR
  */
  public static function __callStatic(string $method, array $parameters)
  {
- $callable = [VCRFactory::get('VCR\Videorecorder'), $method];
+ $callable = [VCRFactory::get(Videorecorder::class), $method];
 
  Assertion::isCallable($callable);
 

tests/VCR/ConfigurationTest.php

@@ -18,8 +18,8 @@ protected function setUp(): void
 
  public function testSetCassettePathThrowsErrorOnInvalidPath(): void
  {
- $this->expectException(
-  VCRException::class,
+ $this->expectException(VCRException::class);
+ $this->expectExceptionMessage(
  "Cassette path 'invalid_path' is not a directory. Please either "
  .'create it or set a different cassette path using '
  ."\\VCR\\VCR::configure()->setCassettePath('directory')."
@@ -63,7 +63,8 @@ public function testEnableSingleLibraryHook(): void
 
  public function testEnableLibraryHooksFailsWithWrongHookName(): void
  {
- $this->expectException('InvalidArgumentException', "Library hooks don't exist: non_existing");
+ $this->expectException(\InvalidArgumentException::class);
+ $this->expectExceptionMessage("Library hooks don't exist: non_existing");
  $this->config->enableLibraryHooks(['non_existing']);
  }
 
@@ -81,13 +82,15 @@ public function testEnableRequestMatchers(): void
 
  public function testEnableRequestMatchersFailsWithNoExistingName(): void
  {
- $this->expectException('InvalidArgumentException', "Request matchers don't exist: wrong, name");
+ $this->expectException(\InvalidArgumentException::class);
+ $this->expectExceptionMessage("Request matchers don't exist: wrong, name");
  $this->config->enableRequestMatchers(['wrong', 'name']);
  }
 
  public function testAddRequestMatcherFailsWithNoName(): void
  {
- $this->expectException('VCR\VCRException', "A request matchers name must be at least one character long. Found ''");
+ $this->expectException(\VCR\VCRException::class);
+ $this->expectExceptionMessage("A request matchers name must be at least one character long. Found ''");
  $expected = function ($first, $second) {
  return true;
  };
@@ -122,7 +125,8 @@ public function availableStorageProvider()
 
  public function testSetStorageInvalidName(): void
  {
- $this->expectException('VCR\VCRException', "Storage 'Does not exist' not available.");
+ $this->expectException(\VCR\VCRException::class);
+ $this->expectExceptionMessage("Storage 'Does not exist' not available.");
  $this->config->setStorage('Does not exist');
  }
 
@@ -154,7 +158,8 @@ public function testBlacklist(): void
 
  public function testSetModeInvalidName(): void
  {
- $this->expectException('VCR\VCRException', "Mode 'invalid' does not exist.");
+ $this->expectException(\VCR\VCRException::class);
+ $this->expectExceptionMessage("Mode 'invalid' does not exist.");
  $this->config->setMode('invalid');
  }
 }

tests/VCR/RequestTest.php

@@ -62,10 +62,8 @@ public function testDoesntMatch(): void
  public function testMatchesThrowsExceptionIfMatcherNotFound(): void
  {
  $request = new Request('POST', 'http://example.com', ['User-Agent' => 'Unit-Test']);
- $this->expectException(
- '\BadFunctionCallException',
- "Matcher could not be executed. Array\n(\n [0] => some\n [1] => method\n)\n"
- );
+ $this->expectException(\BadFunctionCallException::class);
+ $this->expectExceptionMessage("Matcher could not be executed. Array\n(\n [0] => some\n [1] => method\n)\n");
  $this->request->matches($request, [['some', 'method']]);
  }
 

tests/VCR/Storage/AbstractStorageTest.php

@@ -28,7 +28,8 @@ public function testFilePathCreated(): void
 
  public function testRootNotExisting(): void
  {
- $this->expectException('\VCR\VCRException', "Cassette path 'vfs://test/foo' is not existing or not a directory");
+ $this->expectException(\VCR\VCRException::class);
+ $this->expectExceptionMessage("Cassette path 'vfs://test/foo' is not existing or not a directory");
 
  vfsStream::setup('test');
  new TestStorage(vfsStream::url('test/foo'), 'file');

tests/VCR/Util/CurlHelperTest.php

@@ -165,13 +165,15 @@ public function testSetCurlOptionReadFunctionToNull(): void
 
  public function testInvalidHostException(): void
  {
- $this->expectException(InvalidHostException::class, 'URL must be valid.');
+ $this->expectException(InvalidHostException::class);
+ $this->expectExceptionMessage('Could not read host from URL "example.com". Please check the URL syntax.');
  new Request('POST', 'example.com');
  }
 
  public function testSetCurlOptionReadFunctionMissingSize(): void
  {
- $this->expectException('\VCR\VCRException', 'To set a CURLOPT_READFUNCTION, CURLOPT_INFILESIZE must be set.');
+ $this->expectException(\VCR\VCRException::class);
+ $this->expectExceptionMessage('To set a CURLOPT_READFUNCTION, CURLOPT_INFILESIZE must be set.');
  $request = new Request('POST', 'http://example.com');
 
  $callback = function ($curlHandle, $fileHandle, $size): void {

tests/VCR/VCRTest.php

@@ -22,10 +22,8 @@ public static function setupBeforeClass(): void
  public function testUseStaticCallsNotInitialized(): void
  {
  VCR::configure()->enableLibraryHooks(['stream_wrapper']);
- $this->expectException(
- 'VCR\VCRException',
- 'Please turn on VCR before inserting a cassette, use: VCR::turnOn()'
- );
+ $this->expectException(\VCR\VCRException::class);
+ $this->expectExceptionMessage('Please turn on VCR before inserting a cassette, use: VCR::turnOn()');
  VCR::insertCassette('some_name');
  }
 
@@ -103,8 +101,8 @@ public function testShouldNotInterceptCallsToDevUrandom(): void
 
  public function testShouldThrowExceptionIfNoCassettePresent(): void
  {
- $this->expectException(
-  'BadMethodCallException',
+ $this->expectException(\BadMethodCallException::class);
+ $this->expectExceptionMessage(
  'Invalid http request. No cassette inserted. Please make sure to insert '
  ."a cassette in your unit test using VCR::insertCassette('name');"
  );

tests/VCR/VideorecorderTest.php

@@ -61,8 +61,8 @@ public function setCassette(Cassette $cassette): void
 
  public function testHandleRequestThrowsExceptionWhenModeIsNone(): void
  {
- $this->expectException(
-  'LogicException',
+ $this->expectException(\LogicException::class);
+ $this->expectExceptionMessage(
  "The request does not match a previously recorded request and the 'mode' is set to 'none'. "
  ."If you want to send the request anyway, make sure your 'mode' is set to 'new_episodes'."
  );
@@ -109,8 +109,8 @@ public function setCassette(Cassette $cassette): void
 
  public function testHandleRequestThrowsExceptionWhenModeIsOnceAndCassetteIsOld(): void
  {
- $this->expectException(
-  'LogicException',
+ $this->expectException(\LogicException::class);
+ $this->expectExceptionMessage(
  "The request does not match a previously recorded request and the 'mode' is set to 'once'. "
  ."If you want to send the request anyway, make sure your 'mode' is set to 'new_episodes'."
  );