Fix issues with parsing ampersands (#80)

Author: adriangl

CHANGELOG.md

@@ -48,14 +48,15 @@ poEditor {
 ```
 
 </details>
+
 ### Changed
 - Refactor the whole parsing logic to better handle input and improve performance.
 ### Deprecated
 - No deprecated features!
 ### Removed
 - No removed features!
 ### Fixed
-- No fixed issues!
+- Fix bug with `&` character not being properly escaped.
 ### Security
 - No security issues fixed!
 

README.md

@@ -123,7 +123,7 @@ Attribute | Description
 ```resFileName``` | (Since 3.1.0) (Optional) Sets the file name for the imported string resource XML files. Defaults to `strings`.
 ```order``` | (Since 3.1.0) (Optional) Defines how to order the export. Accepted values are defined by the POEditor API.
 ```unquoted``` | (Since 3.2.0) (Optional) Defines if the strings should be unquoted, overriding default PoEditor configuration. Defaults to `false`.
-```unescapeHtmlTags``` | (Since 3.4.0) (Optional) Whether or not to unescape HTML entitites from strings. Defaults to `true`.
+```unescapeHtmlTags``` | (Since 3.4.0) (Optional) Whether or not to unescape HTML tags (`<`, `>`) from strings. Defaults to `true`.
 ```untranslatableStringsRegex``` | (Since 4.2.0) (Optional) Pattern to use to mark strings as translatable=false in the strings file. Defaults to `null`.
 ```includeComments``` | (Since 5.0.0) (Optional) Whether to include comments from the downloaded strings. Defaults to `true`.
 

src/main/kotlin/com/hyperdevs/poeditor/gradle/extensions/StringExtensions.kt

@@ -26,9 +26,6 @@ private val cdataRegex = Regex("^<!\\[CDATA\\[(.*)]]>$", RegexOption.DOT_MATCHES
 fun String.unescapeHtmlTags() = this
  .replace("&lt;", "<")
  .replace("&gt;", ">")
- .replace("&amp;", "&")
- .replace("&apos;", "'")
- .replace("&quot;", "\"")
 
 /**
  * Returns if the given string is a CDATA string.

src/test/kotlin/com/hyperdevs/poeditor/gradle/xml/StringsXmlPostProcessorTest.kt

@@ -431,24 +431,6 @@ class StringsXmlPostProcessorTest {
  assertEquals(expectedResult, StringsXmlPostProcessor.formatTranslationXml(inputStringsXmlDocument, true, null, true))
  }
 
- @Test
- fun `Postprocessing XML with string HTML symbols works 2`() {
- // Test complete Xml
- val inputStringsXmlDocument = StringsXmlDocument(
- resources = listOf(
- StringsXmlResource.StringElement("hello_friend_bold", "<b>Hello world</b>")
- )
- )
-
- val expectedResult = StringsXmlDocument(
- resources = listOf(
- StringsXmlResource.StringElement("hello_friend_bold", "<b>Hello world</b>")
- )
- )
-
- assertEquals(expectedResult, StringsXmlPostProcessor.formatTranslationXml(inputStringsXmlDocument, true, null, true))
- }
-
  @Test
  fun `Postprocessing XML with string HTML symbols and unescape set to false works`() {
  // Test complete Xml