fix: exclude large source code from backtrace (#1440)

Author: subzero10

packages/core/src/util.ts

@@ -151,8 +151,9 @@ export async function getSourceForBacktrace(backtrace: BacktraceFrame[],
  while (backtrace.length) {
  const trace = backtrace.splice(0)[index]
 
- const fileContent = await getSourceFileHandler(trace.file)
- result[index] = getSourceCodeSnippet(fileContent, trace.number)
+ const fileContent = await getSourceFileHandler(trace.file) 
+ result[index] = getSourceCodeSnippet(fileContent, trace.number, trace.column, 2)
+ 
  index++
  }
  return result
@@ -542,13 +543,39 @@ export function clone<T>(obj: T): T {
  return JSON.parse(JSON.stringify(obj))
 }
 
-function getSourceCodeSnippet(fileData: string, lineNumber: number, sourceRadius = 2): Record<string, string> {
+const THRESHOLD_COLUMN_NUMBER = 10000
+const THRESHOLD_LINE_LENGTH = 10000
+const THRESHOLD_FILE_SIZE = 200000 // 200KB threshold
+
+function getThresholdExceededSnippet(lineNumber: number) {
+ return { [lineNumber]: 'SOURCE_SIZE_TOO_LARGE' }
+}
+
+function getSourceCodeSnippet(fileData: string, lineNumber: number, columnNumber: number, sourceRadius = 2): Record<string, string> | null {
  if (!fileData) {
  return null
  }
+
+ // If column number is provided and very high, it's likely a bundled/minified file
+ if (columnNumber && columnNumber > THRESHOLD_COLUMN_NUMBER) {
+ return getThresholdExceededSnippet(lineNumber)
+ }
+
+ // If file is very large, it's likely bundled
+ if (fileData.length > THRESHOLD_FILE_SIZE) {
+ return getThresholdExceededSnippet(lineNumber)
+ }
+
  const lines = fileData.split('\n')
  // add one empty line because array index starts from 0, but error line number is counted from 1
  lines.unshift('')
+ 
+ // Check if the target line is extremely long
+ const targetLine = lines[lineNumber]
+ if (targetLine && targetLine.length > THRESHOLD_LINE_LENGTH) {
+ return getThresholdExceededSnippet(lineNumber)
+ }
+
  const start = lineNumber - sourceRadius
  const end = lineNumber + sourceRadius
  const result = {}

packages/core/test/util.test.ts

@@ -10,7 +10,8 @@ import {
  logger,
  filter,
  filterUrl,
- logDeprecatedMethod
+ logDeprecatedMethod,
+ getSourceForBacktrace
 } from '../src/util'
 import { nullLogger, TestClient, TestTransport } from './helpers'
 
@@ -348,4 +349,106 @@ describe('utils', function () {
  expect(warnSpy).toHaveBeenCalledTimes(2)
  })
  })
+
+ describe('getSourceForBacktrace minified/bundled detection', function () {
+ it('excludes files with high column numbers (bundled/minified)', async function () {
+ const mockGetSourceFile = async (_path: string): Promise<string> => {
+ return 'normal source code content'
+ }
+
+ const backtrace = [{
+ file: '/path/to/bundled.js',
+ method: 'someFunction',
+ number: 1,
+ column: 141907
+ }]
+
+ const result = await getSourceForBacktrace(backtrace, mockGetSourceFile)
+ expect(result[0]['1']).toBe('SOURCE_SIZE_TOO_LARGE')
+ })
+
+ it('includes normal source files with reasonable column numbers', async function () {
+ const mockGetSourceFile = async (_path: string): Promise<string> => {
+ const normalSource = [
+ 'function example() {',
+ ' const someVariable = "this is a normal line"',
+ ' return someVariable',
+ '}',
+ '// This is a comment',
+ 'console.log("test")'
+ ].join('\n')
+ return normalSource
+ }
+
+ const backtrace = [{
+ file: '/path/to/normal.js',
+ method: 'example',
+ number: 2,
+ column: 10
+ }]
+
+ const result = await getSourceForBacktrace(backtrace, mockGetSourceFile)
+ expect(result[0]).not.toBeNull()
+ expect(result[0]['1']).toBe('function example() {')
+ expect(result[0]['2']).toBe(' const someVariable = "this is a normal line"')
+ expect(result[0]['3']).toBe(' return someVariable')
+ })
+
+ it('handles empty or null file content gracefully', async function () {
+ const mockGetSourceFile = async (_path: string): Promise<string> => {
+ return null
+ }
+
+ const backtrace = [{
+ file: '/path/to/missing.js',
+ method: 'someFunction',
+ number: 1,
+ column: 1
+ }]
+
+ const result = await getSourceForBacktrace(backtrace, mockGetSourceFile)
+ expect(result[0]).toBeNull()
+ })
+
+ it('detects large bundled files and excludes them', async function () {
+ const mockGetSourceFile = async (_path: string): Promise<string> => {
+ const largeContent = 'console.log("test");\n'.repeat(50000)
+ return largeContent
+ }
+
+ const backtrace = [{
+ file: '/path/to/large-bundle.js',
+ method: 'someFunction',
+ number: 1000,
+ column: 10
+ }]
+
+ const result = await getSourceForBacktrace(backtrace, mockGetSourceFile)
+ expect(result[0]['1000']).toBe('SOURCE_SIZE_TOO_LARGE')
+ })
+
+ it('detects files with very long lines and excludes them', async function () {
+ const mockGetSourceFile = async (_path: string): Promise<string> => {
+ const longLine = 'a'.repeat(10100)
+ const content = [
+ 'function test() {',
+ ` const x = "${longLine}"`,
+ ' return x',
+ '}'
+ ].join('\n')
+ return content
+ }
+
+ const backtrace = [{
+ file: '/path/to/long-line.js',
+ method: 'test',
+ number: 2,
+ column: 10
+ }]
+
+ const result = await getSourceForBacktrace(backtrace, mockGetSourceFile)
+ expect(result[0]['2']).toBe('SOURCE_SIZE_TOO_LARGE')
+ })
+
+ })
 })