Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Commit 4d748f5

Browse files
committed
Drop CPP directives guarding GHC 8.2.2 statements
1 parent 257eda5 commit 4d748f5

File tree

12 files changed

+1
-74
lines changed

12 files changed

+1
-74
lines changed

hie-plugin-api/Haskell/Ide/Engine/ArtifactMap.hs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,7 @@ genImportMap tm = moduleMap
9292
where
9393
(_, lImports, mlies, _) = fromJust $ GHC.tm_renamed_source tm
9494

95-
#if __GLASGOW_HASKELL__ > 802
9695
lies = map fst $ fromMaybe [] mlies
97-
#else
98-
lies = fromMaybe [] mlies
99-
#endif
10096

10197
moduleMap :: ModuleMap
10298
moduleMap = foldl goImp IM.empty lImports `IM.union` foldl goExp IM.empty lies

hie-plugin-api/Haskell/Ide/Engine/Compat.hs

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,12 @@ isExtensionOf ext = isSuffixOf ('.':ext) . takeExtensions
3737
#endif
3838

3939

40-
#if MIN_VERSION_ghc(8, 4, 0)
4140
type GhcTc = GHC.GhcTc
42-
#else
43-
type GhcTc = GHC.Id
44-
#endif
4541

4642
pattern HsOverLitType :: Type.Type -> GHC.HsExpr GhcTc
4743
pattern HsOverLitType t <-
4844
#if MIN_VERSION_ghc(8, 6, 0)
4945
GHC.HsOverLit _ (GHC.overLitType -> t)
50-
#elif MIN_VERSION_ghc(8, 4, 0)
51-
GHC.HsOverLit (GHC.overLitType -> t)
5246
#else
5347
GHC.HsOverLit (GHC.overLitType -> t)
5448
#endif
@@ -57,8 +51,6 @@ pattern HsLitType :: Type.Type -> GHC.HsExpr GhcTc
5751
pattern HsLitType t <-
5852
#if MIN_VERSION_ghc(8, 6, 0)
5953
GHC.HsLit _ (TcHsSyn.hsLitType -> t)
60-
#elif MIN_VERSION_ghc(8, 4, 0)
61-
GHC.HsLit (TcHsSyn.hsLitType -> t)
6254
#else
6355
GHC.HsLit (TcHsSyn.hsLitType -> t)
6456
#endif
@@ -67,8 +59,6 @@ pattern HsLamType :: Type.Type -> GHC.HsExpr GhcTc
6759
pattern HsLamType t <-
6860
#if MIN_VERSION_ghc(8, 6, 0)
6961
GHC.HsLam _ ((\(GHC.MG { GHC.mg_ext = groupTy }) -> matchGroupType groupTy) -> t)
70-
#elif MIN_VERSION_ghc(8, 4, 0)
71-
GHC.HsLam (\GHC.MG { GHC.mg_res_ty = res, GHC.mg_arg_tys = args } -> Type.mkFunTys args res -> t)
7262
#else
7363
GHC.HsLam (\GHC.MG { GHC.mg_res_ty = res, GHC.mg_arg_tys = args } -> Type.mkFunTys args res -> t)
7464
#endif
@@ -77,8 +67,6 @@ pattern HsLamCaseType :: Type.Type -> GHC.HsExpr GhcTc
7767
pattern HsLamCaseType t <-
7868
#if MIN_VERSION_ghc(8, 6, 0)
7969
GHC.HsLamCase _ ((\(GHC.MG { GHC.mg_ext = groupTy }) -> matchGroupType groupTy) -> t)
80-
#elif MIN_VERSION_ghc(8, 4, 0)
81-
GHC.HsLamCase (\GHC.MG { GHC.mg_res_ty = res, GHC.mg_arg_tys = args } -> Type.mkFunTys args res -> t)
8270
#else
8371
GHC.HsLamCase (\GHC.MG { GHC.mg_res_ty = res, GHC.mg_arg_tys = args } -> Type.mkFunTys args res -> t)
8472
#endif
@@ -87,8 +75,6 @@ pattern HsCaseType :: Type.Type -> GHC.HsExpr GhcTc
8775
pattern HsCaseType t <-
8876
#if MIN_VERSION_ghc(8, 6, 0)
8977
GHC.HsCase _ _ ((\(GHC.MG { GHC.mg_ext = groupTy }) -> matchGroupType groupTy) -> t)
90-
#elif MIN_VERSION_ghc(8, 4, 0)
91-
GHC.HsCase _ (\GHC.MG { GHC.mg_res_ty = res, GHC.mg_arg_tys = args } -> Type.mkFunTys args res -> t)
9278
#else
9379
GHC.HsCase _ (\GHC.MG { GHC.mg_res_ty = res, GHC.mg_arg_tys = args } -> Type.mkFunTys args res -> t)
9480
#endif
@@ -97,8 +83,6 @@ pattern ExplicitListType :: Type.Type -> GHC.HsExpr GhcTc
9783
pattern ExplicitListType t <-
9884
#if MIN_VERSION_ghc(8, 6, 0)
9985
GHC.ExplicitList (TysWiredIn.mkListTy -> t) _ _
100-
#elif MIN_VERSION_ghc(8, 4, 0)
101-
GHC.ExplicitList (TysWiredIn.mkListTy -> t) _ _
10286
#else
10387
GHC.ExplicitList (TysWiredIn.mkListTy -> t) _ _
10488
#endif
@@ -107,8 +91,6 @@ pattern ExplicitSumType :: Type.Type -> GHC.HsExpr GhcTc
10791
pattern ExplicitSumType t <-
10892
#if MIN_VERSION_ghc(8, 6, 0)
10993
GHC.ExplicitSum (TysWiredIn.mkSumTy -> t) _ _ _
110-
#elif MIN_VERSION_ghc(8, 4, 0)
111-
GHC.ExplicitSum _ _ _ (TysWiredIn.mkSumTy -> t)
11294
#else
11395
GHC.ExplicitSum _ _ _ (TysWiredIn.mkSumTy -> t)
11496
#endif
@@ -118,8 +100,6 @@ pattern HsMultiIfType :: Type.Type -> GHC.HsExpr GhcTc
118100
pattern HsMultiIfType t <-
119101
#if MIN_VERSION_ghc(8, 6, 0)
120102
GHC.HsMultiIf t _
121-
#elif MIN_VERSION_ghc(8, 4, 0)
122-
GHC.HsMultiIf t _
123103
#else
124104
GHC.HsMultiIf t _
125105
#endif
@@ -128,8 +108,6 @@ pattern FunBindType :: Type.Type -> GHC.HsBindLR GhcTc GhcTc
128108
pattern FunBindType t <-
129109
#if MIN_VERSION_ghc(8, 6, 0)
130110
GHC.FunBind _ (GHC.L _ (Var.varType -> t)) _ _ _
131-
#elif MIN_VERSION_ghc(8, 4, 0)
132-
GHC.FunBind (GHC.L _ (Var.varType -> t)) _ _ _ _
133111
#else
134112
GHC.FunBind (GHC.L _ (Var.varType -> t)) _ _ _ _
135113
#endif
@@ -138,8 +116,6 @@ pattern FunBindGen :: Type.Type -> GHC.MatchGroup GhcTc (GHC.LHsExpr GhcTc) -> G
138116
pattern FunBindGen t fmatches <-
139117
#if MIN_VERSION_ghc(8, 6, 0)
140118
GHC.FunBind _ (GHC.L _ (Var.varType -> t)) fmatches _ _
141-
#elif MIN_VERSION_ghc(8, 4, 0)
142-
GHC.FunBind (GHC.L _ (Var.varType -> t)) fmatches _ _ _
143119
#else
144120
GHC.FunBind (GHC.L _ (Var.varType -> t)) fmatches _ _ _
145121
#endif
@@ -148,10 +124,8 @@ pattern AbsBinds :: GHC.LHsBinds GhcTc -> GHC.HsBindLR GhcTc GhcTc
148124
pattern AbsBinds bs <-
149125
#if MIN_VERSION_ghc(8, 6, 0)
150126
GHC.AbsBinds _ _ _ _ _ bs _
151-
#elif MIN_VERSION_ghc(8, 4, 0)
152-
GHC.AbsBinds _ _ _ _ bs _
153127
#else
154-
GHC.AbsBinds _ _ _ _ bs
128+
GHC.AbsBinds _ _ _ _ bs _
155129
#endif
156130

157131
#if MIN_VERSION_ghc(8, 6, 0)

src/Haskell/Ide/Engine/Options.hs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
{-# LANGUAGE CPP #-}
22
module Haskell.Ide.Engine.Options where
33

4-
#if __GLASGOW_HASKELL__ < 804
5-
import Data.Semigroup hiding (option)
6-
#endif
74
import Options.Applicative.Simple
85

96
data GlobalOpts = GlobalOpts

src/Haskell/Ide/Engine/Plugin/ApplyRefact.hs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
{-# LANGUAGE CPP #-}
21
{-# LANGUAGE DeriveAnyClass #-}
32
{-# LANGUAGE DeriveGeneric #-}
43
{-# LANGUAGE DuplicateRecordFields #-}
@@ -27,11 +26,7 @@ import Haskell.Ide.Engine.PluginUtils
2726
import Language.Haskell.Exts.SrcLoc
2827
import Language.Haskell.Exts.Parser
2928
import Language.Haskell.Exts.Extension
30-
#if (defined(MIN_VERSION_GLASGOW_HASKELL) && (MIN_VERSION_GLASGOW_HASKELL(8,4,0,0)))
3129
import Language.Haskell.HLint4 as Hlint
32-
#else
33-
import Language.Haskell.HLint3 as Hlint
34-
#endif
3530
import qualified Language.Haskell.LSP.Types as LSP
3631
import qualified Language.Haskell.LSP.Types.Lens as LSP
3732
import Refact.Apply

src/Haskell/Ide/Engine/Plugin/Base.hs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ import Data.Aeson
1111
import Data.Foldable
1212
import qualified Data.Map as Map
1313
import Data.Maybe
14-
#if __GLASGOW_HASKELL__ < 804
15-
import Data.Semigroup
16-
#endif
1714
import qualified Data.Text as T
1815
import qualified Data.Versions as V
1916
import Development.GitRev (gitCommitCount)

src/Haskell/Ide/Engine/Plugin/Build.hs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,7 @@ module Haskell.Ide.Engine.Plugin.Build where
1313
#endif
1414

1515
import qualified Data.Aeson as J
16-
#if __GLASGOW_HASKELL__ < 802
17-
import qualified Data.Aeson.Types as J
18-
#endif
1916
import Data.Maybe (fromMaybe)
20-
#if __GLASGOW_HASKELL__ < 804
21-
import Data.Monoid
22-
#endif
2317
import Control.Monad
2418
import Control.Monad.IO.Class
2519
import Control.Monad.Trans.Reader

src/Haskell/Ide/Engine/Plugin/Example2.hs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
{-# LANGUAGE CPP #-}
21
{-# LANGUAGE DeriveAnyClass #-}
32
{-# LANGUAGE DeriveGeneric #-}
43
{-# LANGUAGE DuplicateRecordFields #-}
@@ -9,9 +8,6 @@ import Control.Lens
98
import Control.Monad.IO.Class
109
import Data.Aeson
1110
import qualified Data.HashMap.Strict as H
12-
#if __GLASGOW_HASKELL__ < 804
13-
import Data.Monoid
14-
#endif
1511
import qualified Data.Map as Map
1612
import qualified Data.Set as S
1713
import qualified Data.Text as T

src/Haskell/Ide/Engine/Plugin/HaRe.hs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
{-# LANGUAGE CPP #-}
21
{-# LANGUAGE DeriveGeneric #-}
32
{-# LANGUAGE NamedFieldPuns #-}
43
{-# LANGUAGE OverloadedStrings #-}
@@ -14,9 +13,6 @@ import qualified Data.Aeson.Types as J
1413
import Data.Algorithm.Diff
1514
import Data.Algorithm.DiffOutput
1615
import Data.Foldable
17-
#if __GLASGOW_HASKELL__ < 804
18-
import Data.Monoid
19-
#endif
2016
import qualified Data.Text as T
2117
import qualified Data.Text.IO as T
2218
import Exception

src/Haskell/Ide/Engine/Plugin/Haddock.hs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
{-# LANGUAGE CPP #-}
21
{-# LANGUAGE NamedFieldPuns #-}
32
{-# LANGUAGE OverloadedStrings #-}
43
{-# LANGUAGE RankNTypes #-}
@@ -9,9 +8,6 @@ module Haskell.Ide.Engine.Plugin.Haddock where
98
import Control.Monad.State
109
import Data.Foldable
1110
import qualified Data.Map as Map
12-
#if __GLASGOW_HASKELL__ < 804
13-
import Data.Monoid
14-
#endif
1511
import qualified Data.Text as T
1612
import Data.IORef
1713
import Data.Function
@@ -195,9 +191,7 @@ renderMarkDown =
195191
["```\n"])
196192
, markupHeader = \h ->
197193
T.replicate (headerLevel h) "#" <> " " <> headerTitle h <> "\n"
198-
#if __GLASGOW_HASKELL__ >= 804
199194
, markupTable = mempty
200-
#endif
201195
}
202196
where surround c x = c <> T.replace c "" x <> c
203197
removeInner x = T.replace "```" "" $ T.replace "```haskell" "" x

src/Haskell/Ide/Engine/Plugin/Hoogle.hs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{-# LANGUAGE TupleSections #-}
22
{-# LANGUAGE LambdaCase #-}
3-
{-# LANGUAGE CPP #-}
43
{-# LANGUAGE OverloadedStrings #-}
54
module Haskell.Ide.Engine.Plugin.Hoogle where
65

@@ -11,9 +10,6 @@ import Control.Applicative (liftA2)
1110
import Data.Aeson
1211
import Data.Bifunctor
1312
import Data.Maybe
14-
#if __GLASGOW_HASKELL__ < 804
15-
import Data.Monoid
16-
#endif
1713
import qualified Data.Text as T
1814
import Data.List
1915
import Haskell.Ide.Engine.MonadTypes

0 commit comments

Comments
 (0)