Skip to content

internal/gocore: disambiguate type candidates by object size #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

internal/gocore: disambiguate type candidates by object size #11

wants to merge 7 commits into from

Conversation

@doujiang24
Copy link
Contributor

@doujiang24 doujiang24 commented Jul 24, 2022 •
edited
Loading

Match the object size when there are multiple candidates for the pointers to structs with the same struct name and same package name.
Also, allow - in the package path.
@gopherbot
Copy link
Contributor

gopherbot commented Jul 24, 2022

This PR (HEAD: 0f81fd8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Jul 29, 2022

Message from Keith Randall:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jul 30, 2022

This PR (HEAD: 0e1d767) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Jul 30, 2022

Message from DeJiang Zhu:

Patch Set 2:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jul 31, 2022

Message from Keith Randall:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

This PR (HEAD: d4ee246) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

Message from DeJiang Zhu:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

Message from Keith Randall:

Patch Set 3: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 2, 2022

This PR (HEAD: 44eaf0c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Aug 2, 2022

Message from DeJiang Zhu:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 2, 2022

Message from Keith Randall:

Patch Set 4: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 2, 2022

Message from Keith Randall:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 3, 2022

This PR (HEAD: 3cd191c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Aug 3, 2022

Message from DeJiang Zhu:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 3, 2022

Message from Keith Randall:

Patch Set 5: Run-TryBot+1 Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 3, 2022

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 3, 2022

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 4, 2022

This PR (HEAD: e25a802) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Aug 4, 2022

Message from DeJiang Zhu:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 4, 2022

Message from Keith Randall:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 4, 2022

Message from Matthew Dempsky:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@doujiang24 doujiang24 changed the title gcore: match the object size when there are multiple candidates for the pointers to structs with same struct name and same package name. internal/gocore: disambiguate type candidates by object size Aug 5, 2022
@gopherbot
Copy link
Contributor

gopherbot commented Aug 5, 2022

Message from DeJiang Zhu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 10, 2022

Message from DeJiang Zhu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 15, 2022

Message from Keith Randall:

Patch Set 7: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 15, 2022

Message from Than McIntosh:

Patch Set 7: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 15, 2022

Message from David Chase:

Patch Set 7: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
@doujiang24
gcore: match the object size when there are multiple candidates for t…
108c57a 
…he pointers to structs with same struct name and same package name. Also, allow `-` in the package path.
@gopherbot
Copy link
Contributor

gopherbot commented Aug 16, 2022

This PR (HEAD: 5b48ab1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Aug 16, 2022

Message from DeJiang Zhu:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176.
After addressing review feedback, remember to publish your drafts!
gopherbot pushed a commit that referenced this pull request Aug 16, 2022
@doujiang24 @randall77
internal/gocore: disambiguate type candidates by object size
1c80bd2 
Match the object size when there are multiple candidates for the pointers to structs with the same struct name and same package name. Also, allow `-` in the package path. Change-Id: Ie3b75aa4ab26283bb94c4c0c40d5c196656caf5f GitHub-Last-Rev: 5b48ab1 GitHub-Pull-Request: #11 Reviewed-on: https://go-review.googlesource.com/c/debug/+/419176 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
@gopherbot
Copy link
Contributor

gopherbot commented Aug 16, 2022

This PR is being closed because golang.org/cl/419176 has been merged.
@gopherbot gopherbot closed this Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@doujiang24 @gopherbot