Skip to content

add context support #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

add context support #148

merged 1 commit into from
May 22, 2020

Conversation

@mkaczanowski
Copy link
Contributor

@mkaczanowski mkaczanowski commented May 15, 2020 •
edited
Loading

Context support is a must-have these days. The buntdb doesn't seem to support context but other databases do, such as Redis, MySQL, etc.

This diff adds context support.

Test plan:

  1. Unit tests are passing
  2. Manually compiled example server and client and run manual test

Original issue: #65
@mkaczanowski mkaczanowski mentioned this pull request May 15, 2020
Closed
@mkaczanowski
Copy link
Contributor Author

mkaczanowski commented May 18, 2020

@LyricTian would you have a moment to look at this? Thanks in advance :)
@LyricTian LyricTian merged commit e627a7b into go-oauth2:master May 22, 2020
@mkaczanowski
Copy link
Contributor Author

mkaczanowski commented May 22, 2020

hey @LyricTian,
thanks for merging. Do you think you could cut v4 version:

https://gopkg.in/oauth2.v4

This would allow people to use the context and more importantly, other drivers could be upgraded as well, i.e: https://github.com/go-oauth2/mysql

Thanks!
@LyricTian
Copy link
Member

LyricTian commented May 22, 2020

OK,Has been upgrade to gopkg.in/oauth2.v4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mkaczanowski @LyricTian