Remove hooks, they belong to Gitaly now

Author: jacobvosmaer

README.md

@@ -20,7 +20,7 @@ An overview of the four cases described above:
 
 ## Git hooks
 
-For historical reasons the gitlab-shell repository also contains the
+The gitlab-shell repository used to also contain the
 Git hooks that allow GitLab to validate Git pushes (e.g. "is this user
 allowed to push to this protected branch"). These hooks also trigger
 events in GitLab (e.g. to start a CI pipeline after a push). 
@@ -30,17 +30,13 @@ require direct disk access to Git repositories, and that is only
 possible on Gitaly servers. It makes no sense to have to install
 gitlab-shell on Gitaly servers.
 
-As of GitLab 11.9 [the actual Git hooks are in the Gitaly
+As of GitLab 11.10  [the actual Git hooks are in the Gitaly
 repository](https://gitlab.com/gitlab-org/gitaly/tree/v1.22.0/ruby/vendor/gitlab-shell/hooks),
 but gitlab-shell must still be installed on Gitaly servers because the
 hooks rely on configuration data (e.g. the GitLab internal API URL) that
 is not yet available in Gitaly itself. Also see the [transition
 plan](https://gitlab.com/gitlab-org/gitaly/issues/1226#note_126519133).
 
-This means that for GitLab 11.9 and up, it is pointless to make changes
-to Git hook code in the gitlab-shell repository, because the code that
-gets run is in the Gitaly repository instead.
-
 ## Code status
 
 [![pipeline status](https://gitlab.com/gitlab-org/gitlab-shell/badges/master/pipeline.svg)](https://gitlab.com/gitlab-org/gitlab-shell/commits/master)

hooks/post-receive

@@ -1,22 +1,4 @@
-#!/usr/bin/env ruby
+#!/bin/sh
+echo "The gitlab-shell hooks have been migrated to Gitaly, see https://gitlab.com/gitlab-org/gitaly/issues/1226"
+exit 1
 
-# This file was placed here by GitLab. It makes sure that your pushed commits
-# will be processed properly.
-
-refs = $stdin.read
-key_id = ENV.delete('GL_ID')
-gl_repository = ENV['GL_REPOSITORY']
-repo_path = Dir.pwd
-
-require_relative '../lib/gitlab_custom_hook'
-require_relative '../lib/hooks_utils'
-require_relative '../lib/gitlab_post_receive'
-
-push_options = HooksUtils.get_push_options
-
-if GitlabPostReceive.new(gl_repository, repo_path, key_id, refs, push_options).exec &&
- GitlabCustomHook.new(repo_path, key_id).post_receive(refs)
- exit 0
-else
- exit 1
-end

hooks/pre-receive

@@ -1,32 +1,4 @@
-#!/usr/bin/env ruby
+#!/bin/sh
+echo "The gitlab-shell hooks have been migrated to Gitaly, see https://gitlab.com/gitlab-org/gitaly/issues/1226"
+exit 1
 
-# This file was placed here by GitLab. It makes sure that your pushed commits
-# will be processed properly.
-
-refs = $stdin.read
-key_id = ENV.delete('GL_ID')
-protocol = ENV.delete('GL_PROTOCOL')
-repo_path = Dir.pwd
-gl_repository = ENV['GL_REPOSITORY']
-
-def increase_reference_counter(gl_repository, repo_path)
- result = GitlabNet.new.pre_receive(gl_repository)
-
- result && result['reference_counter_increased']
-end
-
-require_relative '../lib/gitlab_custom_hook'
-require_relative '../lib/gitlab_access'
-require_relative '../lib/gitlab_net'
-
-# It's important that on pre-receive `increase_reference_counter` gets executed
-# last so that it only runs if everything else succeeded. On post-receive on the
-# other hand, we run GitlabPostReceive first because the push is already done
-# and we don't want to skip it if the custom hook fails.
-if GitlabAccess.new(gl_repository, repo_path, key_id, refs, protocol).exec &&
- GitlabCustomHook.new(repo_path, key_id).pre_receive(refs) &&
- increase_reference_counter(gl_repository, repo_path)
- exit 0
-else
- exit 1
-end

hooks/update

@@ -1,18 +1,4 @@
-#!/usr/bin/env ruby
+#!/bin/sh
+echo "The gitlab-shell hooks have been migrated to Gitaly, see https://gitlab.com/gitlab-org/gitaly/issues/1226"
+exit 1
 
-# This file was placed here by GitLab. It makes sure that your pushed commits
-# will be processed properly.
-
-ref_name = ARGV[0]
-old_value = ARGV[1]
-new_value = ARGV[2]
-repo_path = Dir.pwd
-key_id = ENV.delete('GL_ID')
-
-require_relative '../lib/gitlab_custom_hook'
-
-if GitlabCustomHook.new(repo_path, key_id).update(ref_name, old_value, new_value)
- exit 0
-else
- exit 1
-end

lib/gitlab_access.rb

@@ -3,7 +3,6 @@
 require 'json'
 
 require_relative 'gitlab_config'
-require_relative 'gitlab_access'
 require_relative 'gitlab_lfs_authentication'
 require_relative 'http_helper'