Skip to content

Conversation

@lishaduck
Copy link
Contributor

As per #1439 (comment).

Passes attw, publint.

We can probably drop some of the babel deps now, but I don't know enough about mocha & babel-node to know what.

@lishaduck
Copy link
Contributor Author

Anything else you'd like changed?

@brettz9
Copy link
Collaborator

brettz9 commented Aug 4, 2025

No, just need some time to review.

@brettz9
Copy link
Collaborator

brettz9 commented Aug 4, 2025

While the results are better on attw, there are these resolution errors still:

image
@lishaduck
Copy link
Contributor Author

lishaduck commented Aug 4, 2025

While the results are better on attw, there are these resolution errors still:

Those are for the node10 resolution mode, which has been discouraged for years, is no longer the default in TS 5.9, and will be removed in TS 7.
I'll fix the main entrypoint, but fixing the rest requires a bunch of nasty hacks just to support projects that are using ~unsupported settings.

@brettz9
Copy link
Collaborator

brettz9 commented Aug 5, 2025

I undid the Node10 fixes and removed the Babel dependencies we can remove.

If there is no CLI for unplugin-unused, and there is no script, can we remove that too now?

@lishaduck
Copy link
Contributor Author

unplugin-unused is an (optional) dependency of tsdown. It checks that the dist is consistent with what gets bundled.

@brettz9 brettz9 merged commit af03395 into gajus:main Aug 5, 2025
4 checks passed
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

🎉 This PR is included in version 52.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lishaduck lishaduck deleted the rebuild branch August 6, 2025 01:56
brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this pull request Aug 6, 2025
brettz9 added a commit that referenced this pull request Aug 6, 2025
@brettz9
Copy link
Collaborator

brettz9 commented Aug 6, 2025

Unfortunately had to revert this due to #1443.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants