future.h: replace std::mutex with firebase::Mutex #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dconeybe added skip-release-notes 
github-actions bot added tests: in-progress 
❌ Integration test FAILEDRequested by @dconeybe on commit 283082f
Add flaky tests to go/fpl-cpp-flake-tracker |
github-actions bot added the tests: succeeded 
firebase-workflow-trigger bot removed the tests: in-progress 
jonsimantov reviewed Dec 22, 2021
jonsimantov approved these changes Dec 22, 2021
github-actions bot added tests: in-progress firebase-workflow-trigger bot removed the tests: in-progress DellaBitta added a commit that referenced this pull request Jan 21, 2022
* Add a delay to the Analytics test app. (#788) * Add a delay when the Analytics test finishes. * In the test report, if test failed on all devices. Mark [All x test devices] (#784) * Disable -Wnullability-completeness on iOS and macOS. (#782) * Disable -Wnullability-completeness on iOS and macOS. * Remove NDK if the cache hit failed. * Update public documentation for C++ FCM SDK. (#789) As of Firebase C++ SDK 7.1.0, we started using JobIntentService for scheduling jobs. This change requires a few additional modifications to AndroidManifest.xml and a new way of starting a background service. These changes were done to the old repository, and need to be brought to GitHub. * Split mutex.h into .h and .cc files (#751) * future.h: Fix minor typo in the docs for FutureBase (#794) * Move mutex.h header to public internal (#792) * Delete app/src/mutex.h and adjust includes to app/src/include/firebase/internal/mutex.h (#795) * future.h: replace std::mutex with firebase::Mutex (#798) * Change setup-gcloud to use @v0 instead of @master as per their readme. (#802) * fix Log NoneType Error (#807) * Update Android dependencies - Thu Jan 06 2022 (#809) [Triggered](https://github.com/firebase/firebase-android-sdk/actions/runs/1665092765) by [firebase-android-sdk Jan 06 release](firebase/firebase-android-sdk@22ee484). ### Android - com.google.android.gms.play_services_base → 18.0.1 - com.google.firebase.firebase_analytics → 20.0.2 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1665095030). Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> * add -DNOMINMAX to both WIN32 and WIN64 (#810) * add -DNOMINMAX to both WIN32 and WIN64 * test * test * test * test * remove helper print * format code Co-authored-by: Cynthia Jiang <cynthiajiang@google.com> * In the Test Summary Report, add "x/y" which means "x" out of "y" configs has errors. (#812) * mutex header include path * maven connectivity parameters (#818) CI scripts invoke gradle in a way to circumvent Azure-to-Maven connection pool timeout issues. Co-authored-by: Jon Simantov <jsimantov@google.com> Co-authored-by: Mou Sun <69009538+sunmou99@users.noreply.github.com> Co-authored-by: a-maurice <amaurice@google.com> Co-authored-by: Denver Coneybeare <dconeybe@google.com> Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com> Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: Cynthia J <cynthiajoan@users.noreply.github.com> Co-authored-by: Cynthia Jiang <cynthiajiang@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replace
std::mutexwithfirebase::Mutexinfuture.h.This is the fourth, and last, PR (the previous ones being #751, #792, and #795) towards moving
firebase::Mutexinto the public-internal includes directory, so that it can be used byfuture.h. See #747 for the rationale.Googlers can see b/206520921 for more details.