Skip to content

Commit 7f43aee

Browse files
committed
Because the "boringssl" target doesn't actually run the mobile tests,
set the matrix target to "openssl" but just treat it like boringssl later.
1 parent eeac015 commit 7f43aee

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

.github/workflows/integration_tests.yml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ jobs:
7070
# If building against a packaged SDK, only use boringssl.
7171
if [[ -n "${{ github.event.inputs.downloadPreviousRun }}" ]]; then
7272
echo "::warning ::Downloading SDK package from previous run at https://github.com/firebase/firebase-cpp-sdk/actions/runs/${{ github.event.inputs.downloadPreviousRun }}"
73-
echo "::set-output name=matrix_ssl::$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${EXPANDED_MATRIX_PARAM} -k ssl_lib -o boringssl )"
73+
# Because the mobile tests require this value to be set to 'openssl', set it to 'openssl' here but don't actually install openssl later.
74+
echo "::set-output name=matrix_ssl::$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${EXPANDED_MATRIX_PARAM} -k ssl_lib -o openssl )"
7475
else
7576
echo "::set-output name=matrix_ssl::$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${EXPANDED_MATRIX_PARAM} -k ssl_lib -o "${{github.event.inputs.desktop_ssl_variants}}" )"
7677
fi
@@ -168,14 +169,16 @@ jobs:
168169
- name: Install OpenSSL (windows)
169170
if: matrix.target_platform == 'Desktop' &&
170171
matrix.ssl_variant == 'openssl' &&
171-
startsWith(matrix.os, 'windows')
172+
startsWith(matrix.os, 'windows') &&
173+
${{ github.event.inputs.downloadPreviousRun == '' }}
172174
run: |
173175
choco install openssl -r
174176
175177
- name: Install OpenSSL (MacOS)
176178
if: matrix.target_platform == 'Desktop' &&
177179
matrix.ssl_variant == 'openssl' &&
178-
startsWith(matrix.os, 'macos')
180+
startsWith(matrix.os, 'macos') &&
181+
${{ github.event.inputs.downloadPreviousRun == '' }}
179182
run: |
180183
brew install openssl
181184
# brew won't overwrite MacOS system default OpenSSL, so force it here.
@@ -184,7 +187,8 @@ jobs:
184187
- name: Install OpenSSL (Linux)
185188
if: matrix.target_platform == 'Desktop' &&
186189
matrix.ssl_variant == 'openssl' &&
187-
startsWith(matrix.os, 'ubuntu')
190+
startsWith(matrix.os, 'ubuntu') &&
191+
${{ github.event.inputs.downloadPreviousRun == '' }}
188192
run: |
189193
sudo apt install openssl
190194
@@ -200,8 +204,10 @@ jobs:
200204
cd ..
201205
additional_flags+=(--packaged_sdk downloaded_sdk/firebase_cpp_sdk)
202206
else
203-
# Building integration tests entirely from source.
204-
# Default SSL is openssl.
207+
# Building integration tests against the SDK source.
208+
#
209+
# When building the SDK from source, the default SSL is openssl.
210+
# To build using boringssl, a cmake flag must be added:
205211
if [[ "${{ matrix.ssl_variant }}" == "boringssl" ]]; then
206212
additional_flags+=(--cmake_flag=-DFIREBASE_USE_BORINGSSL=ON)
207213
fi

0 commit comments

Comments
 (0)