Skip to content

Commit 9d9ccc7

Browse files
authored
Upgrade precommit hooks (#253)
* Upgrade pre-commit hooks * Upgrade pre-commit hooks Closes #252
1 parent a59cd3d commit 9d9ccc7

File tree

3 files changed

+79
-109
lines changed

3 files changed

+79
-109
lines changed

.pre-commit-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
fail_fast: true
22
repos:
33
- repo: https://github.com/ambv/black
4-
rev: 22.6.0
4+
rev: 22.8.0
55
hooks:
66
- id: black
77
args: [--diff, --check]
88

99
- repo: https://github.com/pre-commit/mirrors-pylint
10-
rev: v3.0.0a4
10+
rev: v3.0.0a5
1111
hooks:
1212
- id: pylint
1313
args: [--disable=all, --enable=unused-import]
1414

1515
- repo: https://github.com/pre-commit/mirrors-mypy
16-
rev: v0.910
16+
rev: v0.971
1717
hooks:
1818
- id: mypy
1919
exclude: (^tests|^examples|^docs)

tests/test_async_dispatcher.py

Lines changed: 22 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -61,30 +61,24 @@ async def test_dispatch_request():
6161

6262
@pytest.mark.asyncio
6363
async def test_dispatch_deserialized():
64-
assert (
65-
await dispatch_deserialized(
66-
{"ping": ping},
67-
NOCONTEXT,
68-
identity,
69-
{"jsonrpc": "2.0", "method": "ping", "id": 1},
70-
)
71-
== Right(SuccessResponse("pong", 1))
72-
)
64+
assert await dispatch_deserialized(
65+
{"ping": ping},
66+
NOCONTEXT,
67+
identity,
68+
{"jsonrpc": "2.0", "method": "ping", "id": 1},
69+
) == Right(SuccessResponse("pong", 1))
7370

7471

7572
@pytest.mark.asyncio
7673
async def test_dispatch_to_response_pure_success():
77-
assert (
78-
await dispatch_to_response_pure(
79-
deserializer=default_deserializer,
80-
validator=default_validator,
81-
post_process=identity,
82-
context=NOCONTEXT,
83-
methods={"ping": ping},
84-
request='{"jsonrpc": "2.0", "method": "ping", "id": 1}',
85-
)
86-
== Right(SuccessResponse("pong", 1))
87-
)
74+
assert await dispatch_to_response_pure(
75+
deserializer=default_deserializer,
76+
validator=default_validator,
77+
post_process=identity,
78+
context=NOCONTEXT,
79+
methods={"ping": ping},
80+
request='{"jsonrpc": "2.0", "method": "ping", "id": 1}',
81+
) == Right(SuccessResponse("pong", 1))
8882

8983

9084
@patch("jsonrpcserver.async_dispatcher.dispatch_request", side_effect=ValueError("foo"))
@@ -93,14 +87,11 @@ async def test_dispatch_to_response_pure_server_error(*_):
9387
async def foo():
9488
return Success()
9589

96-
assert (
97-
await dispatch_to_response_pure(
98-
deserializer=default_deserializer,
99-
validator=default_validator,
100-
post_process=identity,
101-
context=NOCONTEXT,
102-
methods={"foo": foo},
103-
request='{"jsonrpc": "2.0", "method": "foo", "id": 1}',
104-
)
105-
== Left(ErrorResponse(ERROR_SERVER_ERROR, "Server error", "foo", None))
106-
)
90+
assert await dispatch_to_response_pure(
91+
deserializer=default_deserializer,
92+
validator=default_validator,
93+
post_process=identity,
94+
context=NOCONTEXT,
95+
methods={"foo": foo},
96+
request='{"jsonrpc": "2.0", "method": "foo", "id": 1}',
97+
) == Left(ErrorResponse(ERROR_SERVER_ERROR, "Server error", "foo", None))

tests/test_dispatcher.py

Lines changed: 54 additions & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -281,15 +281,12 @@ def test_not_notification_false():
281281

282282

283283
def test_dispatch_deserialized():
284-
assert (
285-
dispatch_deserialized(
286-
methods={"ping": ping},
287-
context=NOCONTEXT,
288-
post_process=identity,
289-
deserialized={"jsonrpc": "2.0", "method": "ping", "id": 1},
290-
)
291-
== Right(SuccessResponse("pong", 1))
292-
)
284+
assert dispatch_deserialized(
285+
methods={"ping": ping},
286+
context=NOCONTEXT,
287+
post_process=identity,
288+
deserialized={"jsonrpc": "2.0", "method": "ping", "id": 1},
289+
) == Right(SuccessResponse("pong", 1))
293290

294291

295292
# validate_request
@@ -326,17 +323,14 @@ def test_dispatch_request():
326323

327324

328325
def test_dispatch_to_response_pure():
329-
assert (
330-
dispatch_to_response_pure(
331-
deserializer=default_deserializer,
332-
validator=default_validator,
333-
post_process=identity,
334-
context=NOCONTEXT,
335-
methods={"ping": ping},
336-
request='{"jsonrpc": "2.0", "method": "ping", "id": 1}',
337-
)
338-
== Right(SuccessResponse("pong", 1))
339-
)
326+
assert dispatch_to_response_pure(
327+
deserializer=default_deserializer,
328+
validator=default_validator,
329+
post_process=identity,
330+
context=NOCONTEXT,
331+
methods={"ping": ping},
332+
request='{"jsonrpc": "2.0", "method": "ping", "id": 1}',
333+
) == Right(SuccessResponse("pong", 1))
340334

341335

342336
def test_dispatch_to_response_pure_parse_error():
@@ -418,52 +412,43 @@ def foo(colour: str) -> Result:
418412
if colour not in ("orange", "red", "yellow"):
419413
return InvalidParams()
420414

421-
assert (
422-
dispatch_to_response_pure(
423-
deserializer=default_deserializer,
424-
validator=default_validator,
425-
post_process=identity,
426-
context=NOCONTEXT,
427-
methods={"foo": foo},
428-
request='{"jsonrpc": "2.0", "method": "foo", "params": ["blue"], "id": 1}',
429-
)
430-
== Left(ErrorResponse(ERROR_INVALID_PARAMS, "Invalid params", NODATA, 1))
431-
)
415+
assert dispatch_to_response_pure(
416+
deserializer=default_deserializer,
417+
validator=default_validator,
418+
post_process=identity,
419+
context=NOCONTEXT,
420+
methods={"foo": foo},
421+
request='{"jsonrpc": "2.0", "method": "foo", "params": ["blue"], "id": 1}',
422+
) == Left(ErrorResponse(ERROR_INVALID_PARAMS, "Invalid params", NODATA, 1))
432423

433424

434425
def test_dispatch_to_response_pure_internal_error():
435426
def foo():
436427
raise ValueError("foo")
437428

438-
assert (
439-
dispatch_to_response_pure(
440-
deserializer=default_deserializer,
441-
validator=default_validator,
442-
post_process=identity,
443-
context=NOCONTEXT,
444-
methods={"foo": foo},
445-
request='{"jsonrpc": "2.0", "method": "foo", "id": 1}',
446-
)
447-
== Left(ErrorResponse(ERROR_INTERNAL_ERROR, "Internal error", "foo", 1))
448-
)
429+
assert dispatch_to_response_pure(
430+
deserializer=default_deserializer,
431+
validator=default_validator,
432+
post_process=identity,
433+
context=NOCONTEXT,
434+
methods={"foo": foo},
435+
request='{"jsonrpc": "2.0", "method": "foo", "id": 1}',
436+
) == Left(ErrorResponse(ERROR_INTERNAL_ERROR, "Internal error", "foo", 1))
449437

450438

451439
@patch("jsonrpcserver.dispatcher.dispatch_request", side_effect=ValueError("foo"))
452440
def test_dispatch_to_response_pure_server_error(*_):
453441
def foo():
454442
return Success()
455443

456-
assert (
457-
dispatch_to_response_pure(
458-
deserializer=default_deserializer,
459-
validator=default_validator,
460-
post_process=identity,
461-
context=NOCONTEXT,
462-
methods={"foo": foo},
463-
request='{"jsonrpc": "2.0", "method": "foo", "id": 1}',
464-
)
465-
== Left(ErrorResponse(ERROR_SERVER_ERROR, "Server error", "foo", None))
466-
)
444+
assert dispatch_to_response_pure(
445+
deserializer=default_deserializer,
446+
validator=default_validator,
447+
post_process=identity,
448+
context=NOCONTEXT,
449+
methods={"foo": foo},
450+
request='{"jsonrpc": "2.0", "method": "foo", "id": 1}',
451+
) == Left(ErrorResponse(ERROR_SERVER_ERROR, "Server error", "foo", None))
467452

468453

469454
def test_dispatch_to_response_pure_invalid_result():
@@ -495,17 +480,14 @@ def test_dispatch_to_response_pure_raising_exception():
495480
def raise_exception():
496481
raise JsonRpcError(code=0, message="foo", data="bar")
497482

498-
assert (
499-
dispatch_to_response_pure(
500-
deserializer=default_deserializer,
501-
validator=default_validator,
502-
post_process=identity,
503-
context=NOCONTEXT,
504-
methods={"raise_exception": raise_exception},
505-
request='{"jsonrpc": "2.0", "method": "raise_exception", "id": 1}',
506-
)
507-
== Left(ErrorResponse(0, "foo", "bar", 1))
508-
)
483+
assert dispatch_to_response_pure(
484+
deserializer=default_deserializer,
485+
validator=default_validator,
486+
post_process=identity,
487+
context=NOCONTEXT,
488+
methods={"raise_exception": raise_exception},
489+
request='{"jsonrpc": "2.0", "method": "raise_exception", "id": 1}',
490+
) == Left(ErrorResponse(0, "foo", "bar", 1))
509491

510492

511493
# dispatch_to_response_pure -- Notifications
@@ -634,17 +616,14 @@ def test_dispatch_to_response_pure_notification_server_error(*_):
634616
def foo():
635617
return Success()
636618

637-
assert (
638-
dispatch_to_response_pure(
639-
deserializer=default_deserializer,
640-
validator=default_validator,
641-
post_process=identity,
642-
context=NOCONTEXT,
643-
methods={"foo": foo},
644-
request='{"jsonrpc": "2.0", "method": "foo"}',
645-
)
646-
== Left(ErrorResponse(ERROR_SERVER_ERROR, "Server error", "foo", None))
647-
)
619+
assert dispatch_to_response_pure(
620+
deserializer=default_deserializer,
621+
validator=default_validator,
622+
post_process=identity,
623+
context=NOCONTEXT,
624+
methods={"foo": foo},
625+
request='{"jsonrpc": "2.0", "method": "foo"}',
626+
) == Left(ErrorResponse(ERROR_SERVER_ERROR, "Server error", "foo", None))
648627

649628

650629
def test_dispatch_to_response_pure_notification_invalid_result():

0 commit comments

Comments
 (0)